third_party/WebKit/Source/platform/mojo/ReferrerStructTraits.h - Issue 2896443003: Replace remaining ASSERT with DCHECK/_EQ as appropriate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/mojo/ReferrerStructTraits.h

Issue 2896443003: Replace remaining ASSERT with DCHECK/_EQ as appropriate (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/mojo/ReferrerStructTraits.h

diff --git a/third_party/WebKit/Source/platform/mojo/ReferrerStructTraits.h b/third_party/WebKit/Source/platform/mojo/ReferrerStructTraits.h

index 5ebbad66ca3392016e839d748d80dbe985a4e879..299751c6ad002ebdc88e463c5664c729a6fa9649 100644

--- a/third_party/WebKit/Source/platform/mojo/ReferrerStructTraits.h

+++ b/third_party/WebKit/Source/platform/mojo/ReferrerStructTraits.h

@@ -37,7 +37,7 @@ struct StructTraits<blink::mojom::ReferrerDataView, blink::Referrer> {

static_cast<blink::ReferrerPolicy>(webReferrerPolicy);

out->referrer = AtomicString(referrer.GetString());

- // Mimics the ASSERT() done in the blink::Referrer constructor.

+ // Mimics the DCHECK() done in the blink::Referrer constructor.

return referrer.IsValid() || out->referrer == blink::Referrer::NoReferrer();

}

};