Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1468)

Unified Diff: third_party/WebKit/Source/core/page/CreateWindow.cpp

Issue 2896443003: Replace remaining ASSERT with DCHECK/_EQ as appropriate (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/CreateWindow.cpp
diff --git a/third_party/WebKit/Source/core/page/CreateWindow.cpp b/third_party/WebKit/Source/core/page/CreateWindow.cpp
index ba803300e65877345e08666a74c6982c35976295..fe3168b79fc1e746c37716e6c5b753ef5e751717 100644
--- a/third_party/WebKit/Source/core/page/CreateWindow.cpp
+++ b/third_party/WebKit/Source/core/page/CreateWindow.cpp
@@ -130,11 +130,11 @@ static Frame* CreateWindowHelper(LocalFrame& opener_frame,
const WindowFeatures& features,
NavigationPolicy policy,
bool& created) {
- ASSERT(!features.dialog || request.FrameName().IsEmpty());
- ASSERT(request.GetResourceRequest().RequestorOrigin() ||
+ DCHECK(!features.dialog || request.FrameName().IsEmpty());
+ DCHECK(request.GetResourceRequest().RequestorOrigin() ||
opener_frame.GetDocument()->Url().IsEmpty());
- ASSERT(request.GetResourceRequest().GetFrameType() ==
- WebURLRequest::kFrameTypeAuxiliary);
+ DCHECK_EQ(request.GetResourceRequest().GetFrameType(),
+ WebURLRequest::kFrameTypeAuxiliary);
created = false;
@@ -259,7 +259,7 @@ DOMWindow* CreateWindow(const String& url_string,
void CreateWindowForRequest(const FrameLoadRequest& request,
LocalFrame& opener_frame,
NavigationPolicy policy) {
- ASSERT(request.GetResourceRequest().RequestorOrigin() ||
+ DCHECK(request.GetResourceRequest().RequestorOrigin() ||
(opener_frame.GetDocument() &&
opener_frame.GetDocument()->Url().IsEmpty()));

Powered by Google App Engine
This is Rietveld 408576698