Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/WebKit/Source/core/input/EventHandler.cpp

Issue 2896443003: Replace remaining ASSERT with DCHECK/_EQ as appropriate (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/EventHandler.cpp
diff --git a/third_party/WebKit/Source/core/input/EventHandler.cpp b/third_party/WebKit/Source/core/input/EventHandler.cpp
index dc72afdad9c6949bd47ce1ce91fbc5316c683ffc..73ef1c8a4b4735b8759b3ce57ea8572084cabc2e 100644
--- a/third_party/WebKit/Source/core/input/EventHandler.cpp
+++ b/third_party/WebKit/Source/core/input/EventHandler.cpp
@@ -263,7 +263,7 @@ HitTestResult EventHandler::HitTestResultAtPoint(
const LayoutSize& padding) {
TRACE_EVENT0("blink", "EventHandler::hitTestResultAtPoint");
- ASSERT((hit_type & HitTestRequest::kListBased) || padding.IsEmpty());
+ DCHECK((hit_type & HitTestRequest::kListBased) || padding.IsEmpty());
// We always send hitTestResultAtPoint to the main frame if we have one,
// otherwise we might hit areas that are obscured by higher frames.
@@ -1240,7 +1240,7 @@ WebInputEventResult EventHandler::UpdatePointerTargetAndDispatchEvents(
const String& canvas_region_id,
const WebMouseEvent& mouse_event,
const Vector<WebMouseEvent>& coalesced_events) {
- ASSERT(mouse_event_type == EventTypeNames::mousedown ||
+ DCHECK(mouse_event_type == EventTypeNames::mousedown ||
mouse_event_type == EventTypeNames::mousemove ||
mouse_event_type == EventTypeNames::mouseup);
@@ -2023,7 +2023,7 @@ bool EventHandler::HandleTextInputEvent(const String& text,
// Platforms should differentiate real commands like selectAll from text input
// in disguise (like insertNewline), and avoid dispatching text input events
// from keydown default handlers.
- ASSERT(!underlying_event || !underlying_event->IsKeyboardEvent() ||
+ DCHECK(!underlying_event || !underlying_event->IsKeyboardEvent() ||
ToKeyboardEvent(underlying_event)->type() == EventTypeNames::keypress);
if (!frame_)

Powered by Google App Engine
This is Rietveld 408576698