third_party/WebKit/Source/build/scripts/templates/StyleBuilder.cpp.tmpl - Issue 2896443003: Replace remaining ASSERT with DCHECK/_EQ as appropriate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/StyleBuilder.cpp.tmpl

Issue 2896443003: Replace remaining ASSERT with DCHECK/_EQ as appropriate (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/build/scripts/make_css_value_keywords.py ('K') | « third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl ('k') | third_party/WebKit/Source/build/scripts/templates/StylePropertyShorthand.cpp.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/templates/StyleBuilder.cpp.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/StyleBuilder.cpp.tmpl b/third_party/WebKit/Source/build/scripts/templates/StyleBuilder.cpp.tmpl

index bf79041f39c1827546478e6f4e99edea75b2d4a4..6f03df4c9f5d27e7845f51e333f3fd1b47409b91 100644

--- a/third_party/WebKit/Source/build/scripts/templates/StyleBuilder.cpp.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/StyleBuilder.cpp.tmpl

@@ -33,7 +33,7 @@ void StyleBuilder::ApplyProperty(CSSPropertyID property,

{% endfor %}

case CSSPropertyVariable:

- ASSERT(!isInitial && !isInherit);

+ DCHECK(!isInitial && !isInherit);

StyleBuilderFunctions::applyValueCSSPropertyVariable(state, value);

return;

{% for property_id, property in properties.items() if property.direction_aware %}