Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: third_party/WebKit/Source/build/scripts/make_css_value_keywords.py

Issue 2896443003: Replace remaining ASSERT with DCHECK/_EQ as appropriate (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/build/scripts/make_css_value_keywords.py
diff --git a/third_party/WebKit/Source/build/scripts/make_css_value_keywords.py b/third_party/WebKit/Source/build/scripts/make_css_value_keywords.py
index 96546ca5997a2afb3e2acca7b2a127954d50af84..65ff05f3f043e24e416d31f85086acc4b94b6429 100755
--- a/third_party/WebKit/Source/build/scripts/make_css_value_keywords.py
+++ b/third_party/WebKit/Source/build/scripts/make_css_value_keywords.py
@@ -94,7 +94,7 @@ const Value* FindValue(const char* str, unsigned int len) {
}
const char* getValueName(CSSValueID id) {
- ASSERT(id > 0 && id < numCSSValueKeywords);
+ DCHECK(id > 0 && id < numCSSValueKeywords);
haraken 2017/05/19 17:52:03 Split the dcheck into two dchecks. The same commen
return valueListStringPool + valueListStringOffsets[id - 1];
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698