Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 2896423003: Remove Mac input audio restart mechanism and reduce time until startup success check. (Closed)

Created:
3 years, 7 months ago by Henrik Grunell
Modified:
3 years, 7 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, asvitkine+watch_chromium.org, mac-reviews_chromium.org, o1ka, Max Morin
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Mac input audio restart mechanism. Reduce the time until checking startup success from 8 to 5 seconds. Also only set an atomic variable once instead of at every callback. BUG=725819, 549021 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2896423003 Cr-Commit-Position: refs/heads/master@{#474378} Committed: https://chromium.googlesource.com/chromium/src/+/baab05023fbea8af8e626c78899abd87834b70b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -184 lines) Patch
M media/audio/mac/audio_low_latency_input_mac.h View 4 chunks +9 lines, -40 lines 0 comments Download
M media/audio/mac/audio_low_latency_input_mac.cc View 11 chunks +14 lines, -144 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
Henrik Grunell
ossu@ & tommi@: All isherman@: histograms.xml (a simple deprecation)
3 years, 7 months ago (2017-05-24 08:57:10 UTC) #5
ossu-chromium
I've no quarrels with this. LGTM!
3 years, 7 months ago (2017-05-24 09:41:45 UTC) #7
tommi (sloooow) - chröme
lgtm
3 years, 7 months ago (2017-05-24 09:59:07 UTC) #8
Ilya Sherman
LGTM
3 years, 7 months ago (2017-05-24 18:52:36 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896423003/1
3 years, 7 months ago (2017-05-24 18:54:33 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 19:02:16 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/baab05023fbea8af8e626c78899a...

Powered by Google App Engine
This is Rietveld 408576698