Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2896403003: Clean up: remove a non-required @required. (Closed)

Created:
3 years, 7 months ago by lpromero
Modified:
3 years, 7 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up: remove a non-required @required. BUG=675355 R=sdefresne@chromium.org Review-Url: https://codereview.chromium.org/2896403003 Cr-Commit-Position: refs/heads/master@{#474252} Committed: https://chromium.googlesource.com/chromium/src/+/5265ca6a9e1d5baf1f0384a1bf6b2f2c0d90c077

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M ios/chrome/browser/ui/stack_view/stack_view_controller.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
lpromero
3 years, 7 months ago (2017-05-24 09:34:29 UTC) #1
sdefresne
lgtm
3 years, 7 months ago (2017-05-24 11:41:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896403003/1
3 years, 7 months ago (2017-05-24 11:41:33 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 11:46:27 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5265ca6a9e1d5baf1f0384a1bf6b...

Powered by Google App Engine
This is Rietveld 408576698