Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 2896323004: Revert of arc: Invalide app icon on package update. (Closed)

Created:
3 years, 7 months ago by khmel
Modified:
3 years, 7 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, victorhsieh+watch_chromium.org, Matt Giuca
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of arc: Invalide app icon on package update. (patchset #2 id:20001 of https://codereview.chromium.org/2896973002/ ) Reason for revert: Will take a look mem issue Original issue's description: > arc: Invalide app icon on package update. > > ARC app icons need to be invalidated and app icon in app launcher and in > shelf should be automatically updated. > > BUG=725305 > TEST=Manually + unit tests. > > Review-Url: https://codereview.chromium.org/2896973002 > Cr-Commit-Position: refs/heads/master@{#474443} > Committed: https://chromium.googlesource.com/chromium/src/+/1f90c7dc31ae659ff560baebcabfe24c3e036312 TBR=xiyuan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=725305 Review-Url: https://codereview.chromium.org/2896323004 Cr-Commit-Position: refs/heads/master@{#474516} Committed: https://chromium.googlesource.com/chromium/src/+/c92801611913812574def15a03f9ad04b08e9af5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -125 lines) Patch
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc View 7 chunks +32 lines, -51 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_unittest.cc View 2 chunks +1 line, -74 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
khmel
Created Revert of arc: Invalide app icon on package update.
3 years, 7 months ago (2017-05-25 01:45:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896323004/1
3 years, 7 months ago (2017-05-25 01:46:25 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 01:47:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c92801611913812574def15a03f9...

Powered by Google App Engine
This is Rietveld 408576698