Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2896313004: Photo Picker dialog: Handle device orientation changes. (Closed)

Created:
3 years, 7 months ago by Finnur
Modified:
3 years, 7 months ago
Reviewers:
Theresa
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Photo Picker dialog: Handle device orientation changes. BUG=656015 Review-Url: https://codereview.chromium.org/2896313004 Cr-Commit-Position: refs/heads/master@{#474452} Committed: https://chromium.googlesource.com/chromium/src/+/c114d280bcd00241e9981a9ab854c998363175be

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address feedback from Theresa #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -7 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerCategoryView.java View 1 5 chunks +27 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Finnur
3 years, 7 months ago (2017-05-24 13:48:34 UTC) #4
Theresa
https://codereview.chromium.org/2896313004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerCategoryView.java File chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerCategoryView.java (right): https://codereview.chromium.org/2896313004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerCategoryView.java#newcode65 chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerCategoryView.java:65: GridLayoutManager mLayoutManager; nit: make this private https://codereview.chromium.org/2896313004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerCategoryView.java#newcode150 chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerCategoryView.java:150: mLayoutManager.setSpanCount(mColumns); ...
3 years, 7 months ago (2017-05-24 15:15:33 UTC) #7
Finnur
PTAL. https://codereview.chromium.org/2896313004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerCategoryView.java File chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerCategoryView.java (right): https://codereview.chromium.org/2896313004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerCategoryView.java#newcode65 chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerCategoryView.java:65: GridLayoutManager mLayoutManager; On 2017/05/24 15:15:33, Theresa wrote: > ...
3 years, 7 months ago (2017-05-24 15:58:52 UTC) #8
Theresa
lgtm
3 years, 7 months ago (2017-05-24 16:07:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896313004/20001
3 years, 7 months ago (2017-05-24 19:23:58 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 22:31:34 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c114d280bcd00241e9981a9ab854...

Powered by Google App Engine
This is Rietveld 408576698