Photo Picker dialog: Handle device orientation changes.

Photo Picker dialog: Handle device orientation changes.

BUG=656015
Review-Url: https://codereview.chromium.org/2896313004
Cr-Commit-Position: refs/heads/master@{#474452}
Committed: https://chromium.googlesource.com/chromium/src/+/c114d280bcd00241e9981a9ab854c998363175be

[Finnur, 2017-05-24 13:47:47]

The CQ bit was checked by finnur@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 13:47:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Finnur, 2017-05-24 13:48:34]

finnur@chromium.org changed reviewers:
+ twellington@chromium.org

[commit-bot: I haz the power, 2017-05-24 14:28:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 14:28:31]

Dry run: This issue passed the CQ dry run.

[Theresa, 2017-05-24 15:15:33]

https://codereview.chromium.org/2896313004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerCategoryView.java
(right):

https://codereview.chromium.org/2896313004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerCategoryView.java:65:
GridLayoutManager mLayoutManager;
nit: make this private

https://codereview.chromium.org/2896313004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerCategoryView.java:150:
mLayoutManager.setSpanCount(mColumns);
Is it possible that mPadding is also changing and an updated value for that
needs to get passed into the item decoration?

[Finnur, 2017-05-24 15:58:52]

PTAL.

https://codereview.chromium.org/2896313004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerCategoryView.java
(right):

https://codereview.chromium.org/2896313004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerCategoryView.java:65:
GridLayoutManager mLayoutManager;
On 2017/05/24 15:15:33, Theresa wrote:
> nit: make this private

Done.

https://codereview.chromium.org/2896313004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerCategoryView.java:150:
mLayoutManager.setSpanCount(mColumns);
Yes. Updated.

[Theresa, 2017-05-24 16:07:56]

lgtm

[Finnur, 2017-05-24 19:23:08]

The CQ bit was checked by finnur@chromium.org

[commit-bot: I haz the power, 2017-05-24 19:23:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 22:31:19]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495653788314370,
"parent_rev": "34c7a895b3da858147c3bc836b23584a8c01410a", "commit_rev":
"c114d280bcd00241e9981a9ab854c998363175be"}

[commit-bot: I haz the power, 2017-05-24 22:31:33]

Description was changed from

==========
Photo Picker dialog: Handle device orientation changes.

BUG=656015
==========

to

==========
Photo Picker dialog: Handle device orientation changes.

BUG=656015

Review-Url: https://codereview.chromium.org/2896313004
Cr-Commit-Position: refs/heads/master@{#474452}
Committed:
https://chromium.googlesource.com/chromium/src/+/c114d280bcd00241e9981a9ab854...
==========

[commit-bot: I haz the power, 2017-05-24 22:31:34]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c114d280bcd00241e9981a9ab854...