Update cbcs encryption version check for clarity.

Update cbcs encryption version check for clarity.

Make it clearer that the platform bug was fixed in N-MR1. The original
check was correct, but it's easier to be sure that the author doesn't
mean "fixed in O" if the check explicitly refers to N-MR1 instead of
just writing ">N".

BUG=724622
Review-Url: https://codereview.chromium.org/2896303006
Cr-Commit-Position: refs/heads/master@{#475034}
Committed: https://chromium.googlesource.com/chromium/src/+/fc4e84a80b729297c446bc1bf3b0fce67ecfd65f

[Torne, 2017-05-25 17:01:20]

torne@chromium.org changed reviewers:
+ ddorwin@chromium.org, dougsteed@chromium.org

[Torne, 2017-05-25 17:01:21]

See discussion on https://codereview.chromium.org/2906583002/

[dougsteed, 2017-05-25 17:08:05]

lgtm

[ddorwin, 2017-05-25 17:36:28]

LGTM with comment about the existing text.

https://codereview.chromium.org/2896303006/diff/1/media/base/android/java/src...
File media/base/android/java/src/org/chromium/media/MediaCodecUtil.java (right):

https://codereview.chromium.org/2896303006/diff/1/media/base/android/java/src...
media/base/android/java/src/org/chromium/media/MediaCodecUtil.java:628: * DRM
code) which means that it didn't really work properly until N-MR1).
Was the bug in the OS or the Widevine MediaDrm plugin? We might be more specific
here.

[dougsteed, 2017-05-25 17:47:03]

On 2017/05/25 17:36:28, ddorwin wrote:
> LGTM with comment about the existing text.
> 
>
https://codereview.chromium.org/2896303006/diff/1/media/base/android/java/src...
> File media/base/android/java/src/org/chromium/media/MediaCodecUtil.java
(right):
> 
>
https://codereview.chromium.org/2896303006/diff/1/media/base/android/java/src...
> media/base/android/java/src/org/chromium/media/MediaCodecUtil.java:628: * DRM
> code) which means that it didn't really work properly until N-MR1).
> Was the bug in the OS or the Widevine MediaDrm plugin? We might be more
specific
> here.

IIRC, bug was in Widevine plugin.

[Torne, 2017-05-25 18:05:13]

If you give me the text I'll amend the comment to whatever you like. :)

[Torne, 2017-05-26 15:24:22]

I'm going to land this; if you want to amend the text you can do it in another
CL :)

[Torne, 2017-05-26 15:24:25]

The CQ bit was checked by torne@chromium.org

[commit-bot: I haz the power, 2017-05-26 15:24:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 16:52:40]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495812265584970, "parent_rev":
"2f1f15df30c885442a19667207c8b488602572c7", "commit_rev":
"fc4e84a80b729297c446bc1bf3b0fce67ecfd65f"}

[commit-bot: I haz the power, 2017-05-26 16:52:58]

Description was changed from

==========
Update cbcs encryption version check for clarity.

Make it clearer that the platform bug was fixed in N-MR1. The original
check was correct, but it's easier to be sure that the author doesn't
mean "fixed in O" if the check explicitly refers to N-MR1 instead of
just writing ">N".

BUG=724622
==========

to

==========
Update cbcs encryption version check for clarity.

Make it clearer that the platform bug was fixed in N-MR1. The original
check was correct, but it's easier to be sure that the author doesn't
mean "fixed in O" if the check explicitly refers to N-MR1 instead of
just writing ">N".

BUG=724622

Review-Url: https://codereview.chromium.org/2896303006
Cr-Commit-Position: refs/heads/master@{#475034}
Committed:
https://chromium.googlesource.com/chromium/src/+/fc4e84a80b729297c446bc1bf3b0...
==========

[commit-bot: I haz the power, 2017-05-26 16:53:00]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fc4e84a80b729297c446bc1bf3b0...