Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2896303002: [Home] Check if expand button enabled before setting visibility (Closed)

Created:
3 years, 7 months ago by Theresa
Modified:
3 years, 7 months ago
Reviewers:
mdjones
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Home] Check if expand button enabled before setting visibility When a URL focus is in progress, we reset toolbar button visibility. The expand button visibility needs to be guarded on whether the button is enabled. BUG=725392 Review-Url: https://codereview.chromium.org/2896303002 Cr-Commit-Position: refs/heads/master@{#473980} Committed: https://chromium.googlesource.com/chromium/src/+/f4ded7766505e02b0976411dfd813df58fc81aab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Theresa
ptal
3 years, 7 months ago (2017-05-23 16:04:38 UTC) #3
mdjones
lgtm
3 years, 7 months ago (2017-05-23 17:20:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896303002/1
3 years, 7 months ago (2017-05-23 18:07:37 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 18:14:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f4ded7766505e02b0976411dfd81...

Powered by Google App Engine
This is Rietveld 408576698