Fix bug in one conditional. Add more apk test files.

Fix bug in one conditional. Add more apk test files.

BUG=721530
Review-Url: https://codereview.chromium.org/2896273005
Cr-Commit-Position: refs/heads/master@{#474648}
Committed: https://chromium.googlesource.com/chromium/src/+/7451dfbdb556c67f808234f6ec9a76df1a259b18

[ScottK, 2017-05-24 17:29:28]

The CQ bit was checked by scottkirkwood@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 17:30:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ScottK, 2017-05-24 17:31:00]

The CQ bit was checked by scottkirkwood@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 17:31:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ScottK, 2017-05-24 17:32:05]

scottkirkwood@chromium.org changed reviewers:
+ hanxi@chromium.org

[ScottK, 2017-05-24 17:32:06]

One line fix, plus some additional tests.

[Xi Han, 2017-05-24 18:28:52]

lgtm % nit.

https://codereview.chromium.org/2896273005/diff/20001/chrome/android/webapk/l...
File
chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkVerifySignature.java
(right):

https://codereview.chromium.org/2896273005/diff/20001/chrome/android/webapk/l...
chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkVerifySignature.java:383:
return ERROR_BAD_V2_BLOCK;
Can you make this error more meaningful?

[commit-bot: I haz the power, 2017-05-24 19:01:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 19:01:35]

Dry run: This issue passed the CQ dry run.

[ScottK, 2017-05-25 00:26:05]

The CQ bit was checked by scottkirkwood@chromium.org

[ScottK, 2017-05-25 00:26:26]

https://codereview.chromium.org/2896273005/diff/20001/chrome/android/webapk/l...
File
chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkVerifySignature.java
(right):

https://codereview.chromium.org/2896273005/diff/20001/chrome/android/webapk/l...
chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkVerifySignature.java:383:
return ERROR_BAD_V2_BLOCK;
On 2017/05/24 18:28:52, Xi Han wrote:
> Can you make this error more meaningful?

Done.

[commit-bot: I haz the power, 2017-05-25 00:27:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ScottK, 2017-05-25 00:28:13]

The CQ bit was checked by scottkirkwood@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 00:29:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 04:10:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 04:10:31]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[ScottK, 2017-05-25 12:48:21]

The CQ bit was checked by scottkirkwood@chromium.org

[ScottK, 2017-05-25 12:48:22]

The patchset sent to the CQ was uploaded after l-g-t-m from hanxi@chromium.org
Link to the patchset: https://codereview.chromium.org/2896273005/#ps60001
(title: "Change name of enum (int) to be more clear.")

[commit-bot: I haz the power, 2017-05-25 12:48:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 14:36:17]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495716501775130,
"parent_rev": "477e5841d63d6d2b7e548ac51a06e90d6915e72c", "commit_rev":
"7451dfbdb556c67f808234f6ec9a76df1a259b18"}

[commit-bot: I haz the power, 2017-05-25 14:36:35]

Description was changed from

==========
Fix bug in one conditional. Add more apk test files.

BUG=721530
==========

to

==========
Fix bug in one conditional. Add more apk test files.

BUG=721530

Review-Url: https://codereview.chromium.org/2896273005
Cr-Commit-Position: refs/heads/master@{#474648}
Committed:
https://chromium.googlesource.com/chromium/src/+/7451dfbdb556c67f808234f6ec9a...
==========

[commit-bot: I haz the power, 2017-05-25 14:36:36]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/7451dfbdb556c67f808234f6ec9a...