chromeos: converts PanelLayoutManager to aura::Window

chromeos: converts PanelLayoutManager to aura::Window

As well as AlwaysOnTopController.

BUG=722553
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2896273004
Cr-Commit-Position: refs/heads/master@{#474369}
Committed: https://chromium.googlesource.com/chromium/src/+/007c108740cae36d86b5778dee1829a46b8a4ca9

[sky, 2017-05-24 16:43:27]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 16:43:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 17:18:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 17:18:29]

Dry run: This issue passed the CQ dry run.

[sky, 2017-05-24 17:28:44]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 17:29:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2017-05-24 17:50:58]

lgtm with optional nits

https://codereview.chromium.org/2896273004/diff/40001/ash/wm/overview/window_...
File ash/wm/overview/window_selector.cc (right):

https://codereview.chromium.org/2896273004/diff/40001/ash/wm/overview/window_...
ash/wm/overview/window_selector.cc:340: for (aura::Window* window :
Shell::Get()->GetAllRootWindows()) {
optional nit: GetAllRootWindows is static

https://codereview.chromium.org/2896273004/diff/40001/ash/wm/panels/panel_win...
File ash/wm/panels/panel_window_resizer.cc (right):

https://codereview.chromium.org/2896273004/diff/40001/ash/wm/panels/panel_win...
ash/wm/panels/panel_window_resizer.cc:194: if (initial_panel_container_ !=
panel_container_) {
optional nit: curlies not needed

[sky, 2017-05-24 17:59:13]

https://codereview.chromium.org/2896273004/diff/40001/ash/wm/overview/window_...
File ash/wm/overview/window_selector.cc (right):

https://codereview.chromium.org/2896273004/diff/40001/ash/wm/overview/window_...
ash/wm/overview/window_selector.cc:340: for (aura::Window* window :
Shell::Get()->GetAllRootWindows()) {
On 2017/05/24 17:50:58, msw wrote:
> optional nit: GetAllRootWindows is static

Done.

https://codereview.chromium.org/2896273004/diff/40001/ash/wm/panels/panel_win...
File ash/wm/panels/panel_window_resizer.cc (right):

https://codereview.chromium.org/2896273004/diff/40001/ash/wm/panels/panel_win...
ash/wm/panels/panel_window_resizer.cc:194: if (initial_panel_container_ !=
panel_container_) {
On 2017/05/24 17:50:58, msw wrote:
> optional nit: curlies not needed

Done.

[sky, 2017-05-24 17:59:20]

The CQ bit was checked by sky@chromium.org

[sky, 2017-05-24 17:59:21]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2896273004/#ps60001
(title: "feedback")

[commit-bot: I haz the power, 2017-05-24 17:59:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 18:40:12]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495648760663580,
"parent_rev": "55a04e9c19f6754fad6f509cf6854dd35c896071", "commit_rev":
"007c108740cae36d86b5778dee1829a46b8a4ca9"}

[commit-bot: I haz the power, 2017-05-24 18:40:31]

Description was changed from

==========
chromeos: converts PanelLayoutManager to aura::Window

As well as AlwaysOnTopController.

BUG=722553
TEST=covered by tests
R=msw@chromium.org
==========

to

==========
chromeos: converts PanelLayoutManager to aura::Window

As well as AlwaysOnTopController.

BUG=722553
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2896273004
Cr-Commit-Position: refs/heads/master@{#474369}
Committed:
https://chromium.googlesource.com/chromium/src/+/007c108740cae36d86b5778dee18...
==========

[commit-bot: I haz the power, 2017-05-24 18:40:39]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/007c108740cae36d86b5778dee18...