Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2896253004:
[Telemetry] Disable webrtc.multiple_peerconnections story. (Closed)
|
Created:
3 years, 7 months ago by ehmaldonado_chromium Modified:
3 years, 7 months ago CC:
chromium-reviews, telemetry-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[Telemetry] Disable webrtc.multiple_peerconnections story.
It is failing on all platforms.
The previous CL (https://codereview.chromium.org/2899123002) caused builders to break.
BUG=725502, 725796
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=rnephew@chromium.org, nednguyen@google.com, vitaliii@chromium.org
Review-Url: https://codereview.chromium.org/2896253004
Cr-Commit-Position: refs/heads/master@{#474198}
Committed: https://chromium.googlesource.com/chromium/src/+/a1db6b7d87922f09904037e82447170cc97c0a2e
Patch Set 1 #
Messages
Total messages: 24 (13 generated)
Description was changed from ========== [Telemetry] Disable webrtc.multiple_peerconnections story. It is failing on all platforms. BUG=725502 ========== to ========== [Telemetry] Disable webrtc.multiple_peerconnections story. It is failing on all platforms. The previous revert (https://codereview.chromium.org/2899123002) caused builders to break. BUG=725502 TBR=rnephew@chromium.org, nednguyen@google.com, vitaliii@chromium.org ==========
ehmaldonado@webrtc.org changed reviewers: + nednguyen@google.com, rnephew@chromium.org, vitaliii@chromium.org
ehmaldonado@webrtc.org changed reviewers: + ehmaldonado@webrtc.org
The CQ bit was checked by ehmaldonado@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
LGTM
The CQ bit was checked by vitaliii@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [Telemetry] Disable webrtc.multiple_peerconnections story. It is failing on all platforms. The previous revert (https://codereview.chromium.org/2899123002) caused builders to break. BUG=725502 TBR=rnephew@chromium.org, nednguyen@google.com, vitaliii@chromium.org ========== to ========== [Telemetry] Disable webrtc.multiple_peerconnections story. It is failing on all platforms. The previous revert (https://codereview.chromium.org/2899123002) caused builders to break. BUG=725502,725796 TBR=rnephew@chromium.org, nednguyen@google.com, vitaliii@chromium.org ==========
Description was changed from ========== [Telemetry] Disable webrtc.multiple_peerconnections story. It is failing on all platforms. The previous revert (https://codereview.chromium.org/2899123002) caused builders to break. BUG=725502,725796 TBR=rnephew@chromium.org, nednguyen@google.com, vitaliii@chromium.org ========== to ========== [Telemetry] Disable webrtc.multiple_peerconnections story. It is failing on all platforms. The previous CL (https://codereview.chromium.org/2899123002) caused builders to break. BUG=725502,725796 # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true TBR=rnephew@chromium.org, nednguyen@google.com, vitaliii@chromium.org ==========
The CQ bit was unchecked by vitaliii@chromium.org
The CQ bit was checked by vitaliii@chromium.org
The CQ bit was checked by vitaliii@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1495611553322660, "parent_rev":
"a27961af152737aeb934c77180b9667e51bbee06", "commit_rev":
"a1db6b7d87922f09904037e82447170cc97c0a2e"}
Message was sent while issue was closed.
Description was changed from ========== [Telemetry] Disable webrtc.multiple_peerconnections story. It is failing on all platforms. The previous CL (https://codereview.chromium.org/2899123002) caused builders to break. BUG=725502,725796 # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true TBR=rnephew@chromium.org, nednguyen@google.com, vitaliii@chromium.org ========== to ========== [Telemetry] Disable webrtc.multiple_peerconnections story. It is failing on all platforms. The previous CL (https://codereview.chromium.org/2899123002) caused builders to break. BUG=725502,725796 # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true TBR=rnephew@chromium.org, nednguyen@google.com, vitaliii@chromium.org Review-Url: https://codereview.chromium.org/2896253004 Cr-Commit-Position: refs/heads/master@{#474198} Committed: https://chromium.googlesource.com/chromium/src/+/a1db6b7d87922f09904037e82447... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/a1db6b7d87922f09904037e82447...
Message was sent while issue was closed.
On 2017/05/24 07:40:00, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as > https://chromium.googlesource.com/chromium/src/+/a1db6b7d87922f09904037e82447... This is the wrong way of disabling test, Randy: can you fix this on your CL?
Message was sent while issue was closed.
On 2017/05/24 09:55:58, nednguyen wrote: > On 2017/05/24 07:40:00, commit-bot: I haz the power wrote: > > Committed patchset #1 (id:1) as > > > https://chromium.googlesource.com/chromium/src/+/a1db6b7d87922f09904037e82447... > > This is the wrong way of disabling test, Randy: can you fix this on your CL? Please keep in mind that the previous way (https://codereview.chromium.org/2899123002) does not work either.
Message was sent while issue was closed.
On 2017/05/24 11:47:43, vitaliii wrote: > On 2017/05/24 09:55:58, nednguyen wrote: > > On 2017/05/24 07:40:00, commit-bot: I haz the power wrote: > > > Committed patchset #1 (id:1) as > > > > > > https://chromium.googlesource.com/chromium/src/+/a1db6b7d87922f09904037e82447... > > > > This is the wrong way of disabling test, Randy: can you fix this on your CL? > > Please keep in mind that the previous way > (https://codereview.chromium.org/2899123002) does not work either. I am looking into it, and will switch to the new method when it is working properly.
Message was sent while issue was closed.
On 2017/05/24 16:36:32, rnephew (Reviews Here) wrote: > On 2017/05/24 11:47:43, vitaliii wrote: > > On 2017/05/24 09:55:58, nednguyen wrote: > > > On 2017/05/24 07:40:00, commit-bot: I haz the power wrote: > > > > Committed patchset #1 (id:1) as > > > > > > > > > > https://chromium.googlesource.com/chromium/src/+/a1db6b7d87922f09904037e82447... > > > > > > This is the wrong way of disabling test, Randy: can you fix this on your CL? > > > > Please keep in mind that the previous way > > (https://codereview.chromium.org/2899123002) does not work either. > > I am looking into it, and will switch to the new method when it is working > properly. I found the issue is that the smoke tests manipulate the story set in a way that other telemetry tests do not. This does not mesh well with how we ensure story names exist during the run. There is another CL in flight that will add a presubmit check that is not subject to this problem, so we should probably use that validation approach instead. https://codereview.chromium.org/2903023002/ will fix the issue. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
