Do not build FreeType with HarfBuzz support on Android

Do not build FreeType with HarfBuzz support on Android

Originally, building FreeType with HarfBuzz, helped improve autohinting
on Linux, see issue 617168. However, the performance impact we observe
on Android does not seem to justify running autohinting with HarfBuzz
support on Android.

BUG=722980, 724095
Review-Url: https://codereview.chromium.org/2896203002
Cr-Commit-Position: refs/heads/master@{#474221}
Committed: https://chromium.googlesource.com/chromium/src/+/ba0e6cd12bf6f5e864e1f60993ceafef3f4a7cae

[drott, 2017-05-23 08:58:23]

drott@chromium.org changed reviewers:
+ bungeman@chromium.org, dpranke@chromium.org

[drott, 2017-05-23 08:58:28]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 08:58:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 09:05:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 09:05:31]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[drott, 2017-05-23 09:12:50]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 09:13:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 10:39:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 10:39:58]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2017-05-23 19:26:39]

lgtm

https://codereview.chromium.org/2896203002/diff/1/third_party/freetype/BUILD.gn
File third_party/freetype/BUILD.gn (right):

https://codereview.chromium.org/2896203002/diff/1/third_party/freetype/BUILD....
third_party/freetype/BUILD.gn:124: # Using HarfBuzz assisted autohinting has a
performance impact that we do not
Nit: fix the line length / wrapping.

[drott, 2017-05-24 07:34:10]

The CQ bit was checked by drott@chromium.org

[drott, 2017-05-24 07:34:11]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2896203002/#ps20001
(title: "Line length fixed")

[commit-bot: I haz the power, 2017-05-24 07:34:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 09:08:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495611250807000,
"parent_rev": "d9515a4f017409b83c75f5a743678a04dfb047b0", "commit_rev":
"ba0e6cd12bf6f5e864e1f60993ceafef3f4a7cae"}

[commit-bot: I haz the power, 2017-05-24 09:08:56]

Description was changed from

==========
Do not build FreeType with HarfBuzz support on Android

Originally, building FreeType with HarfBuzz, helped improve autohinting
on Linux, see issue 617168. However, the performance impact we observe
on Android does not seem to justify running autohinting with HarfBuzz
support on Android.

BUG=722980, 724095
==========

to

==========
Do not build FreeType with HarfBuzz support on Android

Originally, building FreeType with HarfBuzz, helped improve autohinting
on Linux, see issue 617168. However, the performance impact we observe
on Android does not seem to justify running autohinting with HarfBuzz
support on Android.

BUG=722980, 724095

Review-Url: https://codereview.chromium.org/2896203002
Cr-Commit-Position: refs/heads/master@{#474221}
Committed:
https://chromium.googlesource.com/chromium/src/+/ba0e6cd12bf6f5e864e1f60993ce...
==========

[commit-bot: I haz the power, 2017-05-24 09:08:57]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ba0e6cd12bf6f5e864e1f60993ce...