Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 2896073002: TabManager: Add more logs to understand how it works when memory is low. (Closed)

Created:
3 years, 7 months ago by cylee1
Modified:
3 years, 7 months ago
CC:
chromium-reviews, Yusuke Sato, teravest
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

TabManager: Add more logs to understand how it works when memory is low. BUG=721629 TEST=tried on cave NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2893943003 Cr-Original-Commit-Position: refs/heads/master@{#472970} Review-Url: https://codereview.chromium.org/2896073002 Cr-Commit-Position: refs/branch-heads/3071@{#681} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/2969fddbb9bc81c4f449f19532557ee470197534

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -12 lines) Patch
M chrome/browser/chromeos/arc/process/arc_process.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/process/arc_process.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/memory/tab_manager_delegate_chromeos.cc View 5 chunks +22 lines, -12 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896073002/1
3 years, 7 months ago (2017-05-22 19:46:48 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-22 19:46:52 UTC) #4
cylee1
lgtm
3 years, 7 months ago (2017-05-22 19:47:50 UTC) #5
cylee1
Hi George, This is a a mergeback of https://codereview.chromium.org/2896073002/ to M59. I'm not in OWNERS ...
3 years, 7 months ago (2017-05-22 19:50:16 UTC) #7
cylee1
3 years, 7 months ago (2017-05-22 19:51:12 UTC) #8
Yusuke Sato
lgtm
3 years, 7 months ago (2017-05-23 21:13:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896073002/1
3 years, 7 months ago (2017-05-23 22:41:36 UTC) #12
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 7 months ago (2017-05-23 22:41:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896073002/1
3 years, 7 months ago (2017-05-24 08:08:14 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 08:09:53 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2969fddbb9bc81c4f449f1953255...

Powered by Google App Engine
This is Rietveld 408576698