Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2896063002: [CUPS] Adjust the "Browse" button position a little bit. (Closed)

Created:
3 years, 7 months ago by xdai1
Modified:
3 years, 7 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CUPS] Adjust the "Browse" button position a little bit. BUG=725147 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2896063002 Cr-Commit-Position: refs/heads/master@{#474013} Committed: https://chromium.googlesource.com/chromium/src/+/6926aab403673247827a23fa6ad9795be044626d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
xdai1
michaelpg@, could you help review this CL please? Thanks! (Please refer to the bug to ...
3 years, 7 months ago (2017-05-22 18:22:11 UTC) #3
michaelpg
lgtm
3 years, 7 months ago (2017-05-23 05:42:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896063002/1
3 years, 7 months ago (2017-05-23 17:59:06 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 20:05:23 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6926aab403673247827a23fa6ad9...

Powered by Google App Engine
This is Rietveld 408576698