net/spdy/core/spdy_frame_builder_test.cc - Issue 2895993003: Misc cleanup in net/spdy/core.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/spdy/core/spdy_frame_builder_test.cc

Issue 2895993003: Misc cleanup in net/spdy/core. (Closed)

Patch Set: Rebase. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « net/spdy/core/spdy_frame_builder.cc ('k') | net/spdy/core/spdy_frame_reader.cc » ('j') | net/spdy/core/spdy_framer.cc » ('J')

OLD	NEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "net/spdy/core/spdy_frame_builder.h"	5 #include "net/spdy/core/spdy_frame_builder.h"

6	6

7 #include "net/spdy/core/array_output_buffer.h"	7 #include "net/spdy/core/array_output_buffer.h"

8 #include "net/spdy/core/spdy_framer.h"	8 #include "net/spdy/core/spdy_framer.h"

9 #include "net/spdy/core/spdy_protocol.h"	9 #include "net/spdy/core/spdy_protocol.h"

10 #include "testing/platform_test.h"	10 #include "testing/platform_test.h"

(...skipping 41 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
52	52

53 // Verifies the case that the buffer's capacity is too small.	53 // Verifies the case that the buffer's capacity is too small.

54 TEST(SpdyFrameBuilderTest, GetWritableOutputNegative) {	54 TEST(SpdyFrameBuilderTest, GetWritableOutputNegative) {

55 size_t small_cap = 1;	55 size_t small_cap = 1;

56 ArrayOutputBuffer output(output_buffer, small_cap);	56 ArrayOutputBuffer output(output_buffer, small_cap);

57 const size_t kBuilderSize = 10;	57 const size_t kBuilderSize = 10;

58 SpdyFrameBuilder builder(kBuilderSize, &output);	58 SpdyFrameBuilder builder(kBuilderSize, &output);

59 size_t actual_size = 0;	59 size_t actual_size = 0;

60 char* writable_buffer = builder.GetWritableOutput(kBuilderSize, &actual_size);	60 char* writable_buffer = builder.GetWritableOutput(kBuilderSize, &actual_size);

61 builder.GetWritableOutput(kBuilderSize, &actual_size);	61 builder.GetWritableOutput(kBuilderSize, &actual_size);

62 EXPECT_EQ((uint64_t)0, actual_size);	62 EXPECT_EQ(0u, actual_size);

63 EXPECT_EQ(nullptr, writable_buffer);	63 EXPECT_EQ(nullptr, writable_buffer);

64 }	64 }

65	65

66 } // namespace net	66 } // namespace net

OLD	NEW