Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2895973003: Improvements to GDB debug printers. (Closed)

Created:
3 years, 7 months ago by brettw
Modified:
3 years, 7 months ago
Reviewers:
dcheng
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Improvements to GDB debug printers. The flat_tree pretty-printer is hooked up so that base::flat_set can be displayed. The regular expressions for base::Value were incorrect. These were separated out into three exact matches for clarity. Point and Rect printers were removed. The default view shows the data well enough, and it's confusing to see different member names being printed than the actual class has in it. Review-Url: https://codereview.chromium.org/2895973003 Cr-Commit-Position: refs/heads/master@{#473935} Committed: https://chromium.googlesource.com/chromium/src/+/e5b155aeda665f74830ae3f734982d10fb8dc026

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -24 lines) Patch
M tools/gdb/gdb_chrome.py View 4 chunks +10 lines, -24 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
brettw
3 years, 7 months ago (2017-05-22 22:36:44 UTC) #2
dcheng
LGTM
3 years, 7 months ago (2017-05-23 05:19:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895973003/1
3 years, 7 months ago (2017-05-23 16:35:37 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 16:41:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e5b155aeda665f74830ae3f73498...

Powered by Google App Engine
This is Rietveld 408576698