Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Unified Diff: chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_test_utils.cc

Issue 2895953003: Use SkJpegEncoder in gfx jpeg_codec (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_test_utils.cc
diff --git a/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_test_utils.cc b/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_test_utils.cc
index 87bc037538820ee3b7870f3ecc8054392448c6cd..0d38ae9bbcd83a60f9208edeeac0c5b7d959ae49 100644
--- a/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_test_utils.cc
+++ b/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_test_utils.cc
@@ -90,11 +90,7 @@ bool CreateJPEGImage(int width,
const int kQuality = 80;
if (!gfx::JPEGCodec::Encode(
static_cast<const unsigned char*>(bitmap.getPixels()),
- gfx::JPEGCodec::FORMAT_SkBitmap,
- width,
- height,
- bitmap.rowBytes(),
- kQuality,
+ kN32_SkColorType, width, height, bitmap.rowBytes(), kQuality,
scroggo_chromium 2017/05/30 14:27:52 This parameter list makes me think we should've ta
dcheng 2017/06/02 15:35:00 I agree this would make sense: PNG codec has some
msarett1 2017/06/07 18:01:14 Yeah I think it should take an SkPixmap. SkBitmap
output)) {
LOG(ERROR) << "Unable to encode " << width << "x" << height << " bitmap";
return false;

Powered by Google App Engine
This is Rietveld 408576698