Use SkJpegEncoder in gfx jpeg_codec

chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_test_utils.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_test_utils.h"
 
 #include <stddef.h>
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
@@ skipping 72 matching lines @@
                      int height,
                      SkColor color,
                      std::vector<unsigned char>* output) {
   SkBitmap bitmap;
   bitmap.allocN32Pixels(width, height);
   bitmap.eraseColor(color);
 
   const int kQuality = 80;
   if (!gfx::JPEGCodec::Encode(
           static_cast<const unsigned char*>(bitmap.getPixels()),
-          gfx::JPEGCodec::FORMAT_SkBitmap,
-          width,
-          height,
-          bitmap.rowBytes(),
-          kQuality,
+          kN32_SkColorType, width, height, bitmap.rowBytes(), kQuality,

[scroggo_chromium, 2017/05/30 14:27:52]

This parameter list makes me think we should've taken an SkBitmap (or an
SkPixmap?) as a parameter. (Doesn't need to be in this CL, but something to
consider?)

[dcheng, 2017/06/02 15:35:00]

I agree this would make sense: PNG codec has some encode helpers that take a
SkBitmap parameter.

[msarett1, 2017/06/07 18:01:14]

Yeah I think it should take an SkPixmap.  SkBitmap would be fine as well, but I
think Skia in general is trying to move towards SkImage and SkPixmap.

           output)) {
     LOG(ERROR) << "Unable to encode " << width << "x" << height << " bitmap";
     return false;
   }
   return true;
 }
 
 gfx::ImageSkia CreateTestImage(int width, int height, SkColor color) {
   SkBitmap bitmap;
   bitmap.allocN32Pixels(width, height);
@@ skipping 117 matching lines @@
                             kWallpaperSize,
                             kLargeChildWallpaperColor));
 
   command_line->reset(new base::CommandLine(options));
   WallpaperManager::Get()->SetCommandLineForTesting(command_line->get());
 }
 
 }  // namespace wallpaper_manager_test_utils
 
 }  // namespace chromeos