Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2895953002: Update dangling markup mitigations. (Closed)

Created:
3 years, 7 months ago by Mike West
Modified:
3 years, 7 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-frames_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, kinuko+watch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update dangling markup mitigations. Still behind a flag, just updating the checks to look for both `\n` and `<` rather than just the former. This is in line with the patches up at https://github.com/whatwg/url/pull/284 and https://github.com/whatwg/fetch/pull/519. Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/KaA_YNOlTPk/VmmoV88xBgAJ. BUG=680970

Patch Set 1 #

Patch Set 2 : Tests. #

Patch Set 3 : Test. #

Patch Set 4 : Test. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+352 lines, -231 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bindings/blink-in-js-asan-crash-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/iframes/iframe-in-composited-layer-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/editing/pasteboard/dragstart-contains-default-content-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/fetch/dangling-markup-mitigation.tentative.html View 1 2 3 1 chunk +158 lines, -0 lines 1 comment Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-composite-canvas-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-composite-image-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/counters/counter-traverse-table-cell-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Element/offsetLeft-offsetTop-body-quirk-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/constructors/track-event-constructor-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/drag-and-drop-autoscroll-inner-frame-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/resize-subframe-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/touch/gesture/long-press-focuses-frame-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/files/null-origin-string-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/frames/content-opacity-1-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/frames/negative-remaining-length-crash-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/loader/simultaneous-reloads-assert-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/loader/stateobjects/pushstate-in-data-url-denied-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/loader/url-strip-cr-lf-tab-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-hidden-iframe-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-hidden-iframe-zero-size-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-iframe-nested-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-iframe-no-focusable-content-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-iframe-no-scrollable-content-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-iframe-recursive-offset-parent-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-iframe-with-offscreen-focusable-element-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/dangling-markup/src-attribute.html View 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/dangling-markup/src-attribute-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/document-all-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/no-indexeddb-from-sandbox-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/no-popup-from-sandbox-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/no-popup-from-sandbox-top-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/popup-allowed-by-sandbox-can-navigate-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/popup-allowed-by-sandbox-is-sandboxed-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/popup-allowed-by-sandbox-when-allowed-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/sandboxed-opener-can-close-window-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/window-named-proto-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/window-named-valueOf-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/newline-in-request-uri-expected.txt View 1 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/frames/frameset-style-recalc-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/canvas-composite-repaint-by-all-imagesource-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/canvas-composite-repaint-by-all-imagesource-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/plugins/createScriptableObject-before-start-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/printing/subframes-percentage-height-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/g-outside-svg-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/large-image-pattern-crash-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 3 1 chunk +1 line, -18 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/loader/BaseFetchContext.cpp View 1 2 3 1 chunk +5 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/weborigin/KURL.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/weborigin/KURLTest.cpp View 3 chunks +95 lines, -14 lines 0 comments Download
M url/gurl_unittest.cc View 1 chunk +16 lines, -2 lines 0 comments Download
M url/third_party/mozilla/url_parse.h View 1 chunk +6 lines, -2 lines 0 comments Download
M url/third_party/mozilla/url_parse.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M url/url_canon.h View 1 chunk +10 lines, -3 lines 0 comments Download
M url/url_canon_etc.cc View 3 chunks +19 lines, -9 lines 0 comments Download
M url/url_canon_relative.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M url/url_util.cc View 3 chunks +7 lines, -12 lines 0 comments Download
M url/url_util_unittest.cc View 2 chunks +23 lines, -13 lines 0 comments Download

Messages

Total messages: 20 (17 generated)
Mike West
WDYT, Jochen? This changes the boolean in //url to match the test we're doing in ...
3 years, 7 months ago (2017-05-22 13:25:35 UTC) #4
Mike West
Ping. :) https://codereview.chromium.org/2895953002/diff/60001/third_party/WebKit/LayoutTests/external/wpt/fetch/dangling-markup-mitigation.tentative.html File third_party/WebKit/LayoutTests/external/wpt/fetch/dangling-markup-mitigation.tentative.html (right): https://codereview.chromium.org/2895953002/diff/60001/third_party/WebKit/LayoutTests/external/wpt/fetch/dangling-markup-mitigation.tentative.html#newcode1 third_party/WebKit/LayoutTests/external/wpt/fetch/dangling-markup-mitigation.tentative.html:1: <!DOCTYPE html> This is the actual test. ...
3 years, 7 months ago (2017-05-24 07:10:49 UTC) #17
Mike West
3 years, 7 months ago (2017-05-24 11:04:01 UTC) #20

Powered by Google App Engine
This is Rietveld 408576698