Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: url/url_canon_relative.cc

Issue 2895953002: Update dangling markup mitigations. (Closed)
Patch Set: Test. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: url/url_canon_relative.cc
diff --git a/url/url_canon_relative.cc b/url/url_canon_relative.cc
index 2ee61db24b7dfd642b66eb5e230b264d0a138b82..659aca7fe8c13a87583c848edad7ed7568e5fc42 100644
--- a/url/url_canon_relative.cc
+++ b/url/url_canon_relative.cc
@@ -443,11 +443,11 @@ bool DoResolveRelativeURL(const char* base_url,
Parsed* out_parsed) {
// |base_parsed| is the starting point for our output. Since we may have
// removed whitespace from |relative_url| before entering this method, we'll
- // carry over the |whitespace_removed| flag.
- bool whitespace_removed = out_parsed->whitespace_removed;
+ // carry over the |potentially_dangling_markup| flag.
+ bool potentially_dangling_markup = out_parsed->potentially_dangling_markup;
*out_parsed = base_parsed;
- if (whitespace_removed)
- out_parsed->whitespace_removed = true;
+ if (potentially_dangling_markup)
+ out_parsed->potentially_dangling_markup = true;
// Sanity check: the input should have a host or we'll break badly below.
// We can only resolve relative URLs with base URLs that have hosts and

Powered by Google App Engine
This is Rietveld 408576698