Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: components/sync/engine_impl/commit_util.cc

Issue 2895933003: [Sync] Stop setting SyncEntity.insert_after_item_id in client (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/engine_impl/commit_util.cc
diff --git a/components/sync/engine_impl/commit_util.cc b/components/sync/engine_impl/commit_util.cc
index ccb6200883ab403fa48ad86988a4666cb760c56b..8c2fe0c35ee82409498235237dbe5aa8b89501a8 100644
--- a/components/sync/engine_impl/commit_util.cc
+++ b/components/sync/engine_impl/commit_util.cc
@@ -166,12 +166,8 @@ void BuildCommitItem(const syncable::Entry& meta_entry,
if (meta_entry.GetIsDel()) {
sync_entry->set_deleted(true);
} else {
- // Both insert_after_item_id and position_in_parent fields are set only
- // for legacy reasons. See comments in sync.proto for more information.
- const Id& prev_id = meta_entry.GetPredecessorId();
- string prev_id_string =
- prev_id.IsNull() ? string() : prev_id.GetServerId();
- sync_entry->set_insert_after_item_id(prev_id_string);
+ // position_in_parent field is set only for legacy reasons. See comments
+ // in sync.proto for more information.
sync_entry->set_position_in_parent(
meta_entry.GetUniquePosition().ToInt64());
meta_entry.GetUniquePosition().ToProto(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698