[Sync] Stop setting SyncEntity.insert_after_item_id in client

[Sync] Stop setting SyncEntity.insert_after_item_id in client

Currently client sets insert_after_item_id, but doesn't properly order commit
entries with respect to this field. It causes commit to fail on the server under
certain conditions:
- Two new sibling bookmarks are committed
- They get broken into different commit messages with second bookmark being sent
  in the first message

In this case server either expects server id in the field or bookmark being
referred to in insert_after_item_id being present in the same message.

This field was deprecated since before M26, therefore I'm simply removing the
code that sets this field on the client.

BUG=722487
R=pnoland@chromium.org

Review-Url: https://codereview.chromium.org/2895933003
Cr-Commit-Position: refs/heads/master@{#473721}
Committed: https://chromium.googlesource.com/chromium/src/+/ab5c383a79f5d3ca96239215dd56d81f033f2f8c

[pavely, 2017-05-22 18:06:19]

The CQ bit was checked by pavely@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 18:07:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 19:52:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 19:52:42]

Dry run: This issue passed the CQ dry run.

[Patrick Noland, 2017-05-22 21:58:32]

lgtm

[pavely, 2017-05-22 22:05:34]

The CQ bit was checked by pavely@chromium.org

[commit-bot: I haz the power, 2017-05-22 22:06:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 22:12:45]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495490734927970, "parent_rev":
"b161bd6231fc5c89e2c92931b2d55820762464f7", "commit_rev":
"ab5c383a79f5d3ca96239215dd56d81f033f2f8c"}

[commit-bot: I haz the power, 2017-05-22 22:12:54]

Description was changed from

==========
[Sync] Stop setting SyncEntity.insert_after_item_id in client

Currently client sets insert_after_item_id, but doesn't properly order commit
entries with respect to this field. It causes commit to fail on the server under
certain conditions:
- Two new sibling bookmarks are committed
- They get broken into different commit messages with second bookmark being sent
  in the first message

In this case server either expects server id in the field or bookmark being
referred to in insert_after_item_id being present in the same message.

This field was deprecated since before M26, therefore I'm simply removing the
code that sets this field on the client.

BUG=722487
R=pnoland@chromium.org
==========

to

==========
[Sync] Stop setting SyncEntity.insert_after_item_id in client

Currently client sets insert_after_item_id, but doesn't properly order commit
entries with respect to this field. It causes commit to fail on the server under
certain conditions:
- Two new sibling bookmarks are committed
- They get broken into different commit messages with second bookmark being sent
  in the first message

In this case server either expects server id in the field or bookmark being
referred to in insert_after_item_id being present in the same message.

This field was deprecated since before M26, therefore I'm simply removing the
code that sets this field on the client.

BUG=722487
R=pnoland@chromium.org

Review-Url: https://codereview.chromium.org/2895933003
Cr-Commit-Position: refs/heads/master@{#473721}
Committed:
https://chromium.googlesource.com/chromium/src/+/ab5c383a79f5d3ca96239215dd56...
==========

[commit-bot: I haz the power, 2017-05-22 22:12:55]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ab5c383a79f5d3ca96239215dd56...