Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2895923003: Small interstitial JS cleanup (Closed)

Created:
3 years, 7 months ago by felt
Modified:
3 years, 7 months ago
Reviewers:
Jialiu Lin
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Small interstitial JS cleanup Some code was still hanging around from a deprecated field trial. This CL cleans it up. BUG= Review-Url: https://codereview.chromium.org/2895923003 Cr-Commit-Position: refs/heads/master@{#473686} Committed: https://chromium.googlesource.com/chromium/src/+/4ecb9563608b9759307678598bdde3923eff0df7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M components/security_interstitials/core/browser/resources/interstitial_v2.js View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
felt
jialiul ptal?
3 years, 7 months ago (2017-05-22 20:39:38 UTC) #5
Jialiu Lin
lgtm
3 years, 7 months ago (2017-05-22 20:41:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895923003/1
3 years, 7 months ago (2017-05-22 20:50:13 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 20:56:16 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4ecb9563608b9759307678598bdd...

Powered by Google App Engine
This is Rietveld 408576698