Fix compilation failure due to overload of virtual function

Fix compilation failure due to overload of virtual function

Compilation failure is result to overloaded-virtual warning
treated as error.

BUG=

Review-Url: https://codereview.chromium.org/2895923002
Cr-Commit-Position: refs/heads/master@{#45525}
Committed: https://chromium.googlesource.com/v8/v8/+/709c906a9200b0a1401b58261f311de95707adc0

[ivica.bogosavljevic, 2017-05-22 11:37:18]

The CQ bit was checked by ivica.bogosavljevic@imgtec.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 11:37:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ivica.bogosavljevic, 2017-05-22 11:46:58]

ivica.bogosavljevic@imgtec.com changed reviewers:
+ eholk@chromium.org, jochen@chromium.org, mlippautz@chromium.org

[ivica.bogosavljevic, 2017-05-22 11:46:58]

PTAL

Compilation failure with GYP + Mips cross compile toolchain

[commit-bot: I haz the power, 2017-05-22 12:07:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 12:07:52]

Dry run: This issue passed the CQ dry run.

[Eric Holk, 2017-05-22 16:24:58]

https://codereview.chromium.org/2895923002/diff/1/test/mkgrokdump/mkgrokdump.cc
File test/mkgrokdump/mkgrokdump.cc (right):

https://codereview.chromium.org/2895923002/diff/1/test/mkgrokdump/mkgrokdump....
test/mkgrokdump/mkgrokdump.cc:40: void Free(void* data, size_t length,
AllocationMode mode) override {}
Could you go ahead and add empty implementations of Reserve and SetProtection
too? Those will eventually become pure virtual members or
v8::ArrayBuffer::Allocator, so it'd be good to go ahead and implement them here.

https://codereview.chromium.org/2895923002/diff/1/test/unittests/value-serial...
File test/unittests/value-serializer-unittest.cc (right):

https://codereview.chromium.org/2895923002/diff/1/test/unittests/value-serial...
test/unittests/value-serializer-unittest.cc:1897: void Free(void* data, size_t
length, AllocationMode mode) override {}
Same comment as before, please add Reserve and SetProtection as well.

[ivica.bogosavljevic, 2017-05-23 11:50:27]

Updated according to comments, PTAL

[Eric Holk, 2017-05-23 19:47:50]

lgtm, although you'll need an lgtm from someone with OWNERS before you can land.

[ivica.bogosavljevic, 2017-05-24 13:11:59]

ivica.bogosavljevic@imgtec.com changed reviewers:
+ ahaas@chromium.org

[ivica.bogosavljevic, 2017-05-24 13:11:59]

Fixed the issue, need LGTM from owners.

[Michael Lippautz, 2017-05-24 14:13:05]

lgtm

[ivica.bogosavljevic, 2017-05-24 14:53:16]

The CQ bit was checked by ivica.bogosavljevic@imgtec.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 14:53:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 15:21:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 15:21:36]

Dry run: This issue passed the CQ dry run.

[Eric Holk, 2017-05-24 21:18:26]

The CQ bit was checked by eholk@chromium.org

[commit-bot: I haz the power, 2017-05-24 21:18:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 21:19:48]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495660706501270,
"parent_rev": "cd778f13ac74cd1b46c65901abf2bf94861125aa", "commit_rev":
"709c906a9200b0a1401b58261f311de95707adc0"}

[commit-bot: I haz the power, 2017-05-24 21:19:57]

Description was changed from

==========
Fix compilation failure due to overload of virtual function

Compilation failure is result to overloaded-virtual warning
treated as error.

BUG=
==========

to

==========
Fix compilation failure due to overload of virtual function

Compilation failure is result to overloaded-virtual warning
treated as error.

BUG=

Review-Url: https://codereview.chromium.org/2895923002
Cr-Commit-Position: refs/heads/master@{#45525}
Committed:
https://chromium.googlesource.com/v8/v8/+/709c906a9200b0a1401b58261f311de9570...
==========

[commit-bot: I haz the power, 2017-05-24 21:19:59]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/709c906a9200b0a1401b58261f311de9570...