DevTools: Audits2 use location.href when available

DevTools: Audits2 use location.href when available

* Uses window.location.href over mainTarget.inspectedURL when available

BUG=724558
R=dgozman,paulirish

Review-Url: https://codereview.chromium.org/2895913003
Cr-Commit-Position: refs/heads/master@{#473748}
Committed: https://chromium.googlesource.com/chromium/src/+/a2e8568a2bf96f91c458ab39b0ffa449cebd50b6

[dgozman, 2017-05-22 18:50:34]

https://codereview.chromium.org/2895913003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
(right):

https://codereview.chromium.org/2895913003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:145:
_updateInspectedURL() {
JSDoc please.

https://codereview.chromium.org/2895913003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:147: var
runtimeModel = /** @type {!SDK.RuntimeModel} */
(mainTarget.model(SDK.RuntimeModel));
No need to cast, instead do the following in next line:

var executionContext = runtimeModel && runtimeModel.defaultExecutionContext();

https://codereview.chromium.org/2895913003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:154: return
new Promise((resolve, reject) => {
We don't usually reject promises.

https://codereview.chromium.org/2895913003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:157: return
reject(err || new Error('Failed to retrieve page URL'));
Just resolve with mainTarget.inspectedURL()

[caseq, 2017-05-22 18:53:05]

caseq@chromium.org changed reviewers:
+ caseq@chromium.org

[caseq, 2017-05-22 18:53:06]

https://codereview.chromium.org/2895913003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
(right):

https://codereview.chromium.org/2895913003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:150:
this.inspectedURL = mainTarget.inspectedURL();
did you mean _inspectedURL?

[phulce, 2017-05-22 19:10:17]

https://codereview.chromium.org/2895913003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
(right):

https://codereview.chromium.org/2895913003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:145:
_updateInspectedURL() {
On 2017/05/22 18:50:34, dgozman wrote:
> JSDoc please.

Done.

https://codereview.chromium.org/2895913003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:147: var
runtimeModel = /** @type {!SDK.RuntimeModel} */
(mainTarget.model(SDK.RuntimeModel));
On 2017/05/22 18:50:34, dgozman wrote:
> No need to cast, instead do the following in next line:
> 
> var executionContext = runtimeModel && runtimeModel.defaultExecutionContext();

Done.

https://codereview.chromium.org/2895913003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:150:
this.inspectedURL = mainTarget.inspectedURL();
On 2017/05/22 18:53:06, caseq wrote:
> did you mean _inspectedURL?

whoops, yes :)

https://codereview.chromium.org/2895913003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:154: return
new Promise((resolve, reject) => {
On 2017/05/22 18:50:34, dgozman wrote:
> We don't usually reject promises.

Gotcha, so we have a general preference to silently recover with partial data
rather than fail loudly?

https://codereview.chromium.org/2895913003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:157: return
reject(err || new Error('Failed to retrieve page URL'));
On 2017/05/22 18:50:34, dgozman wrote:
> Just resolve with mainTarget.inspectedURL()

Done.

[dgozman, 2017-05-22 20:48:14]

lgtm

https://codereview.chromium.org/2895913003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
(right):

https://codereview.chromium.org/2895913003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:159:
this._inspectedURL = object.value;
object.release();

[phulce, 2017-05-22 21:57:30]

The CQ bit was checked by phulce@chromium.org

[phulce, 2017-05-22 21:57:30]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2895913003/#ps40001
(title: "release object")

[commit-bot: I haz the power, 2017-05-22 21:57:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 23:44:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495490250150200,
"parent_rev": "55c71f0ff307dfc3b3e561a2f72e90bb3df05393", "commit_rev":
"a2e8568a2bf96f91c458ab39b0ffa449cebd50b6"}

[commit-bot: I haz the power, 2017-05-22 23:44:15]

Description was changed from

==========
DevTools: Audits2 use location.href when available

* Uses window.location.href over mainTarget.inspectedURL when available

BUG=724558
R=dgozman,paulirish
==========

to

==========
DevTools: Audits2 use location.href when available

* Uses window.location.href over mainTarget.inspectedURL when available

BUG=724558
R=dgozman,paulirish

Review-Url: https://codereview.chromium.org/2895913003
Cr-Commit-Position: refs/heads/master@{#473748}
Committed:
https://chromium.googlesource.com/chromium/src/+/a2e8568a2bf96f91c458ab39b0ff...
==========

[commit-bot: I haz the power, 2017-05-22 23:44:18]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a2e8568a2bf96f91c458ab39b0ff...