Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issue 2895873002: Refactored out need to pass property id to ConsumePrefixedBackgroundBox (Closed)

Created:
3 years, 7 months ago by Bugs Nash
Modified:
3 years, 7 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactored out need to pass property id to ConsumePrefixedBackgroundBox BUG=668012 Review-Url: https://codereview.chromium.org/2895873002 Cr-Commit-Position: refs/heads/master@{#473514} Committed: https://chromium.googlesource.com/chromium/src/+/04fa8149930e617b317c48d578fb2386c06e38c1

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 chunks +9 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (12 generated)
Bugs Nash
3 years, 7 months ago (2017-05-22 03:44:45 UTC) #4
shend
lgtm with nits https://codereview.chromium.org/2895873002/diff/1/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right): https://codereview.chromium.org/2895873002/diff/1/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp#newcode1007 third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:1007: if ((allow_text_value) && range.Peek().Id() == CSSValueText) ...
3 years, 7 months ago (2017-05-22 03:46:57 UTC) #5
Bugs Nash
+suzyh for owners https://codereview.chromium.org/2895873002/diff/1/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right): https://codereview.chromium.org/2895873002/diff/1/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp#newcode1007 third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:1007: if ((allow_text_value) && range.Peek().Id() == CSSValueText) ...
3 years, 7 months ago (2017-05-22 03:49:52 UTC) #9
suzyh_UTC10 (ex-contributor)
lgtm
3 years, 7 months ago (2017-05-22 04:09:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895873002/20001
3 years, 7 months ago (2017-05-22 06:19:05 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 06:23:41 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/04fa8149930e617b317c48d578fb...

Powered by Google App Engine
This is Rietveld 408576698