Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2895853002: Unskip tests that that were skipped on May 3. (Closed)

Created:
3 years, 7 months ago by qyearsley
Modified:
3 years, 7 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Unskip tests that that were skipped on May 3. Specifically, this removes the skip lines added in http://crrev.com/c/490551. This import included the addition of one new directory that has no owners, so it is added to the list in NeverFixTests. The purpose of this is to clean up TestExpectations. Review-Url: https://codereview.chromium.org/2895853002 Cr-Commit-Position: refs/heads/master@{#473723} Committed: https://chromium.googlesource.com/chromium/src/+/5c29de4fcc53f7092bf0c22ac057c46326e3687a

Patch Set 1 #

Patch Set 2 : wpt-update-expectations #

Patch Set 3 : rebase #

Patch Set 4 : add one more expectation #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -28 lines) Patch
M third_party/WebKit/LayoutTests/NeverFixTests View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 3 chunks +4 lines, -27 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
qyearsley
3 years, 7 months ago (2017-05-22 16:24:36 UTC) #3
jeffcarp
lgtm
3 years, 7 months ago (2017-05-22 18:01:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895853002/80001
3 years, 7 months ago (2017-05-22 22:08:14 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 22:14:28 UTC) #17
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/5c29de4fcc53f7092bf0c22ac057...

Powered by Google App Engine
This is Rietveld 408576698