chromeos: Eliminate WmWindow from //ash/system

chromeos: Eliminate WmWindow from //ash/system

It's left over from the early days of mustash/mash and we don't need it
anymore.

I left one reference because it'll be easier to clean up when WmShelf
gets converted.

Pure refactor, no behavior changes.

BUG=722552
TEST=ash_unittests, manual tests of chrome stylus tools

Review-Url: https://codereview.chromium.org/2895843002
Cr-Commit-Position: refs/heads/master@{#473709}
Committed: https://chromium.googlesource.com/chromium/src/+/320d7f295bf6705998c40241630638f40a6e7d17

[James Cook, 2017-05-21 18:41:25]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-21 18:41:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-05-21 18:42:02]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2017-05-21 18:42:03]

msw, please take a look.

[commit-bot: I haz the power, 2017-05-21 19:12:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-21 19:12:52]

Dry run: This issue passed the CQ dry run.

[msw, 2017-05-22 18:37:11]

lgtm

https://codereview.chromium.org/2895843002/diff/1/ash/shelf/shelf_widget.cc
File ash/shelf/shelf_widget.cc (right):

https://codereview.chromium.org/2895843002/diff/1/ash/shelf/shelf_widget.cc#n...
ash/shelf/shelf_widget.cc:186: WmWindow::GetAuraWindow(status_container),
wm_shelf_);
optional nit: status_container->aura_window()

https://codereview.chromium.org/2895843002/diff/1/ash/system/palette/palette_...
File ash/system/palette/palette_tool_manager.h (right):

https://codereview.chromium.org/2895843002/diff/1/ash/system/palette/palette_...
ash/system/palette/palette_tool_manager.h:40: class Delegate {
aside: Sigh, this PaletteTool::Delegate subclass has a largely redundant
delegate interface declaration...

https://codereview.chromium.org/2895843002/diff/1/ash/system/palette/palette_...
File ash/system/palette/palette_tray.cc (right):

https://codereview.chromium.org/2895843002/diff/1/ash/system/palette/palette_...
ash/system/palette/palette_tray.cc:312:
RootWindowController::ForWindow(anchor_widget->GetNativeWindow())
aside: We should consolidate that with ash::GetRootWindowController().

https://codereview.chromium.org/2895843002/diff/1/ash/system/palette/palette_...
ash/system/palette/palette_tray.cc:362: return
WmWindow::GetAuraWindow(shelf()->GetWindow());
ditto optional nit: ->aura_window()

[James Cook, 2017-05-22 21:04:54]

Thanks for the review.

https://codereview.chromium.org/2895843002/diff/1/ash/shelf/shelf_widget.cc
File ash/shelf/shelf_widget.cc (right):

https://codereview.chromium.org/2895843002/diff/1/ash/shelf/shelf_widget.cc#n...
ash/shelf/shelf_widget.cc:186: WmWindow::GetAuraWindow(status_container),
wm_shelf_);
On 2017/05/22 18:37:11, msw wrote:
> optional nit: status_container->aura_window()

Done.

https://codereview.chromium.org/2895843002/diff/1/ash/system/palette/palette_...
File ash/system/palette/palette_tray.cc (right):

https://codereview.chromium.org/2895843002/diff/1/ash/system/palette/palette_...
ash/system/palette/palette_tray.cc:312:
RootWindowController::ForWindow(anchor_widget->GetNativeWindow())
On 2017/05/22 18:37:11, msw wrote:
> aside: We should consolidate that with ash::GetRootWindowController().

Yeah. I think we should eliminate ash::GetRootWindowController() - I don't like
bare functions in large namespaces like ash.

https://codereview.chromium.org/2895843002/diff/1/ash/system/palette/palette_...
ash/system/palette/palette_tray.cc:362: return
WmWindow::GetAuraWindow(shelf()->GetWindow());
On 2017/05/22 18:37:11, msw wrote:
> ditto optional nit: ->aura_window()

Done.

[James Cook, 2017-05-22 21:05:02]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2017-05-22 21:05:02]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2895843002/#ps40001
(title: "comments")

[commit-bot: I haz the power, 2017-05-22 21:05:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 21:41:53]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495487102154040,
"parent_rev": "0946bcce0307295e466335001a51fc0e6bc4e8fa", "commit_rev":
"320d7f295bf6705998c40241630638f40a6e7d17"}

[commit-bot: I haz the power, 2017-05-22 21:42:05]

Description was changed from

==========
chromeos: Eliminate WmWindow from //ash/system

It's left over from the early days of mustash/mash and we don't need it
anymore.

I left one reference because it'll be easier to clean up when WmShelf
gets converted.

Pure refactor, no behavior changes.

BUG=722552
TEST=ash_unittests, manual tests of chrome stylus tools
==========

to

==========
chromeos: Eliminate WmWindow from //ash/system

It's left over from the early days of mustash/mash and we don't need it
anymore.

I left one reference because it'll be easier to clean up when WmShelf
gets converted.

Pure refactor, no behavior changes.

BUG=722552
TEST=ash_unittests, manual tests of chrome stylus tools

Review-Url: https://codereview.chromium.org/2895843002
Cr-Commit-Position: refs/heads/master@{#473709}
Committed:
https://chromium.googlesource.com/chromium/src/+/320d7f295bf6705998c402416306...
==========

[commit-bot: I haz the power, 2017-05-22 21:42:06]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/320d7f295bf6705998c402416306...