Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 2895783002: Avoid scaling overlays on systems that don't support them. (Closed)

Created:
3 years, 7 months ago by jbauman
Modified:
3 years, 7 months ago
Reviewers:
sunnyps
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid scaling overlays on systems that don't support them. Most systems that only support direct (unscaled) overlays are Intel Cherry Trail. On these systems we want to make sure overlay swapchains are the size they appear onscreen, so that no scaling is necessary. Otherwise they may be displayed using compositing in DWM, which can be much less efficient. BUG=725208 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2895783002 Cr-Commit-Position: refs/heads/master@{#473828} Committed: https://chromium.googlesource.com/chromium/src/+/54436b450d22d4ce66ea198ab9999c570c28f84e

Patch Set 1 #

Patch Set 2 : fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M gpu/ipc/service/direct_composition_surface_win.cc View 1 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 16 (12 generated)
jbauman
3 years, 7 months ago (2017-05-22 20:12:15 UTC) #10
sunnyps
lgtm
3 years, 7 months ago (2017-05-23 03:05:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895783002/20001
3 years, 7 months ago (2017-05-23 06:45:37 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 07:33:01 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/54436b450d22d4ce66ea198ab999...

Powered by Google App Engine
This is Rietveld 408576698