Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2895773002: (fix landed)Revert of Closure: remove older, original GYP compilation system (Closed)

Created:
3 years, 7 months ago by findit-for-me
Modified:
3 years, 7 months ago
CC:
chromium-reviews, blakeo+virtualkb_chromium.org, oshima+watch_chromium.org, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, oka+watchvk_chromium.org, fukino+watch_chromium.org, yhanada+watchvk_chromium.org, vitalyp+closure_chromium.org, dfaden+virtualkb_google.com, groby+virtualkb_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Closure: remove older, original GYP compilation system (patchset #2 id:20001 of https://codereview.chromium.org/2887253006/ ) Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 473381 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzY4ZjI1NjQ4ZTEzMmNjYjc5OWY2M2U1NzEyYTc2Y2M2OWRjNjNlZDMM Original issue's description: > Closure: remove older, original GYP compilation system > > R=dpranke@chromium.org,sadrul@chromium.org,fukino@chromium.org > BUG=585553 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2887253006 > Cr-Commit-Position: refs/heads/master@{#473381} > Committed: https://chromium.googlesource.com/chromium/src/+/68f25648e132ccb799f63e5712a76cc69dc63ed3 TBR=dpranke@chromium.org,sadrul@chromium.org,fukino@chromium.org,dbeam@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=585553

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+952 lines, -2 lines) Patch
M PRESUBMIT.py View 2 chunks +21 lines, -0 lines 0 comments Download
M PRESUBMIT_test.py View 1 chunk +14 lines, -0 lines 0 comments Download
A components/chrome_apps/webstore_widget/app/compiled_resources.gyp View 1 chunk +42 lines, -0 lines 0 comments Download
A components/chrome_apps/webstore_widget/cws_widget/compiled_resources.gypi View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/closure_compiler/build/inputs.py View 1 chunk +101 lines, -0 lines 0 comments Download
A third_party/closure_compiler/compile.py View 1 chunk +376 lines, -0 lines 0 comments Download
A third_party/closure_compiler/compile_js.gypi View 1 chunk +67 lines, -0 lines 0 comments Download
M third_party/closure_compiler/compile_js2.gypi View 1 chunk +1 line, -1 line 0 comments Download
A third_party/closure_compiler/compiled_resources.gyp View 1 chunk +26 lines, -0 lines 0 comments Download
M third_party/closure_compiler/run_compiler View 1 chunk +3 lines, -1 line 0 comments Download
A third_party/closure_compiler/tools/compile_coverage.py View 1 chunk +128 lines, -0 lines 0 comments Download
A third_party/jstemplate/compiled_resources.gyp View 1 chunk +17 lines, -0 lines 0 comments Download
A ui/file_manager/file_manager/foreground/js/metadata/compiled_resources.gyp View 1 chunk +30 lines, -0 lines 0 comments Download
A ui/keyboard/resources/compiled_resources.gyp View 1 chunk +11 lines, -0 lines 0 comments Download
A ui/webui/resources/js/compiled_resources.gyp View 1 chunk +65 lines, -0 lines 0 comments Download
A ui/webui/resources/js/cr/ui/compiled_resources.gyp View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
findit-for-me
Created Revert of Closure: remove older, original GYP compilation system
3 years, 7 months ago (2017-05-19 23:34:57 UTC) #1
findit-for-me
Sheriffs: Please confirm and "Quick L-G-T-M & CQ" this revert if it is correct. If ...
3 years, 7 months ago (2017-05-19 23:34:59 UTC) #3
Dan Beam
3 years, 7 months ago (2017-05-20 03:07:52 UTC) #4
this was a culprit but it's already been fixed rather than reverted

Powered by Google App Engine
This is Rietveld 408576698