Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2895663002: Fix 'X' and Gear button while viewing Native Pages in VR. (Closed)

Created:
3 years, 7 months ago by mthiesse
Modified:
3 years, 7 months ago
Reviewers:
ymalik
CC:
chromium-reviews, feature-vr-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix 'X' and Gear button while viewing Native Pages in VR. Adds a parent that passes screen taps to the GvrLayout, while passing all generated input to the Native page. BUG=717249 Review-Url: https://codereview.chromium.org/2895663002 Cr-Commit-Position: refs/heads/master@{#473242} Committed: https://chromium.googlesource.com/chromium/src/+/5434cde940c6d24099fa61864545c24b40efb061

Patch Set 1 #

Patch Set 2 : nits #

Patch Set 3 : corretct diffbase #

Patch Set 4 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -11 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java View 1 2 3 7 chunks +20 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mthiesse
PTAL
3 years, 7 months ago (2017-05-19 16:25:45 UTC) #2
ymalik
lgtm, thanks
3 years, 7 months ago (2017-05-19 17:09:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895663002/60001
3 years, 7 months ago (2017-05-19 17:11:25 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 17:57:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/5434cde940c6d24099fa61864545...

Powered by Google App Engine
This is Rietveld 408576698