Speculative fix for PopupMenuTest flakiness

Speculative fix for PopupMenuTest flakiness

SitePerProcessBrowserTest.PopupMenuTest is occasionally flaky on
ChromeOS bots, possibly because a Linux-only section was added in
r459476 that relies on browser process hit testing, but the test does
not call WaitForChildFrameSurfaceReady() to prevent races between hit
tests and compositor frames.

This adds a call to attempt to resolve the flakiness, and does some
unrelated cleanup.

BUG=723657
Review-Url: https://codereview.chromium.org/2895653003
Cr-Commit-Position: refs/heads/master@{#473396}
Committed: https://chromium.googlesource.com/chromium/src/+/66169e7ebec215a59409823ab08f5210ce1fde24

[kenrb, 2017-05-19 20:48:50]

The CQ bit was checked by kenrb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 20:50:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kenrb, 2017-05-19 20:50:17]

kenrb@chromium.org changed reviewers:
+ nasko@chromium.org

[kenrb, 2017-05-19 20:50:18]

nasko: PTAL?

[nasko, 2017-05-19 21:06:45]

LGTM

[commit-bot: I haz the power, 2017-05-19 22:01:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 22:01:48]

Dry run: This issue passed the CQ dry run.

[kenrb, 2017-05-20 00:31:49]

The CQ bit was checked by kenrb@chromium.org

[commit-bot: I haz the power, 2017-05-20 00:32:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-20 00:37:46]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495240309364980, "parent_rev":
"1671f06ee7b3e7ba18d4a8171d3e0c64d95a44b0", "commit_rev":
"66169e7ebec215a59409823ab08f5210ce1fde24"}

[commit-bot: I haz the power, 2017-05-20 00:38:11]

Description was changed from

==========
Speculative fix for PopupMenuTest flakiness

SitePerProcessBrowserTest.PopupMenuTest is occasionally flaky on
ChromeOS bots, possibly because a Linux-only section was added in
r459476 that relies on browser process hit testing, but the test does
not call WaitForChildFrameSurfaceReady() to prevent races between hit
tests and compositor frames.

This adds a call to attempt to resolve the flakiness, and does some
unrelated cleanup.

BUG=723657
==========

to

==========
Speculative fix for PopupMenuTest flakiness

SitePerProcessBrowserTest.PopupMenuTest is occasionally flaky on
ChromeOS bots, possibly because a Linux-only section was added in
r459476 that relies on browser process hit testing, but the test does
not call WaitForChildFrameSurfaceReady() to prevent races between hit
tests and compositor frames.

This adds a call to attempt to resolve the flakiness, and does some
unrelated cleanup.

BUG=723657

Review-Url: https://codereview.chromium.org/2895653003
Cr-Commit-Position: refs/heads/master@{#473396}
Committed:
https://chromium.googlesource.com/chromium/src/+/66169e7ebec215a59409823ab08f...
==========

[commit-bot: I haz the power, 2017-05-20 00:38:12]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/66169e7ebec215a59409823ab08f...