Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 2895633002: Fix comment about "happy eyeballs" IPv4 fallback (Closed)

Created:
6 months, 1 week ago by mgersh
Modified:
6 months, 1 week ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix comment about "happy eyeballs" IPv4 fallback The comment used to claim that in an address list with both IPv6 and IPv4 addresses, the IPv6 addresses will come first, which is usually but not always true. Now it correctly explains that the fallback is only used when an IPv6 address is first. Review-Url: https://codereview.chromium.org/2895633002 Cr-Commit-Position: refs/heads/master@{#473351} Committed: https://chromium.googlesource.com/chromium/src/+/2a552a75bf20b63dc035145a8b2eaef54c1e034c

Patch Set 1 #

Messages

Total messages: 8 (4 generated)
mgersh
PTAL. This has somehow come up twice in one week.
6 months, 1 week ago (2017-05-19 15:26:09 UTC) #2
mmenke
On 2017/05/19 15:26:09, mgersh wrote: > PTAL. This has somehow come up twice in one ...
6 months, 1 week ago (2017-05-19 19:41:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895633002/1
6 months, 1 week ago (2017-05-19 19:43:26 UTC) #5
commit-bot: I haz the power
6 months, 1 week ago (2017-05-19 22:08:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2a552a75bf20b63dc035145a8b2e...

Powered by Google App Engine
This is Rietveld efc10ee0f