Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: net/http/http_stream_factory_impl_job.h

Issue 2895623002: Remove HttpStreamFactoryImpl::Job::ssl_info_. (Closed)
Patch Set: Re: #12. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/http_stream_factory_impl_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_stream_factory_impl_job.h
diff --git a/net/http/http_stream_factory_impl_job.h b/net/http/http_stream_factory_impl_job.h
index 11361536f1881623bf027d8ad81f0b60f2d26b10..2ed056fa0284f49a6a602deb3226152e0bad7816 100644
--- a/net/http/http_stream_factory_impl_job.h
+++ b/net/http/http_stream_factory_impl_job.h
@@ -346,8 +346,7 @@ class HttpStreamFactoryImpl::Job {
// Retrieve SSLInfo from our SSL Socket.
// This must only be called when we are using an SSLSocket.
- // After calling, the caller can use ssl_info_.
- void GetSSLInfo();
+ void GetSSLInfo(SSLInfo* ssl_info);
SpdySessionKey GetSpdySessionKey() const;
@@ -398,7 +397,7 @@ class HttpStreamFactoryImpl::Job {
SSLConfig proxy_ssl_config_;
const NetLogWithSource net_log_;
- CompletionCallback io_callback_;
+ const CompletionCallback io_callback_;
std::unique_ptr<ClientSocketHandle> connection_;
HttpNetworkSession* const session_;
@@ -406,7 +405,6 @@ class HttpStreamFactoryImpl::Job {
State state_;
State next_state_;
- SSLInfo ssl_info_;
// The server we are trying to reach, could be that of the origin or of the
// alternative service (after applying host mapping rules).
@@ -428,7 +426,7 @@ class HttpStreamFactoryImpl::Job {
const bool enable_ip_based_pooling_;
// Unowned. |this| job is owned by |delegate_|.
- Delegate* delegate_;
+ Delegate* const delegate_;
const JobType job_type_;
« no previous file with comments | « no previous file | net/http/http_stream_factory_impl_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698