Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 2895593002: Revert of [subresource_filter] Decide UNSUPPORTED_SCHEME only if we'd otherwise activate (Closed)

Created:
3 years, 7 months ago by Marc Treib
Modified:
3 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, subresource-filter-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [subresource_filter] Decide UNSUPPORTED_SCHEME only if we'd otherwise activate (patchset #3 id:40001 of https://codereview.chromium.org/2888163002/ ) Reason for revert: Depends on https://codereview.chromium.org/2889913002 which is being reverted. Original issue's description: > [subresource_filter] Decide UNSUPPORTED_SCHEME only if we'd otherwise activate > > Right now the subresource filter reports UNSUPPORTED_SCHEME even if the > feature is disabled and the navigation would never have activated. This > patch aligns things closer to how they were before [1] landed, so that > UNSUPPORTED_SCHEME is not logged if the matched configuration's > activation level is DISABLED or there is no matched configuration. > > BUG=todo > > Review-Url: https://codereview.chromium.org/2888163002 > Cr-Commit-Position: refs/heads/master@{#473093} > Committed: https://chromium.googlesource.com/chromium/src/+/a30d68388644568f7930aa57cdd2fa015816aeb9 TBR=bmcquade@chromium.org,csharrison@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=todo Review-Url: https://codereview.chromium.org/2895593002 Cr-Commit-Position: refs/heads/master@{#473154} Committed: https://chromium.googlesource.com/chromium/src/+/d317bdebb9123813be9d28e9ff7b128098dfd8ec

Patch Set 1 #

Messages

Total messages: 6 (3 generated)
Marc Treib
Created Revert of [subresource_filter] Decide UNSUPPORTED_SCHEME only if we'd otherwise activate
3 years, 7 months ago (2017-05-19 10:56:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895593002/1
3 years, 7 months ago (2017-05-19 10:57:11 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 10:57:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d317bdebb9123813be9d28e9ff7b...

Powered by Google App Engine
This is Rietveld 408576698