Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2895583004: fuchsia: Let linker know where to find libclang_rt.builtin.a (Closed)

Created:
3 years, 7 months ago by Nico
Modified:
3 years, 7 months ago
Reviewers:
scottmg
CC:
chromium-reviews, hans, Petr Hosek
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

fuchsia: Let linker know where to find libclang_rt.builtin.a BUG=724204 R=scottmg@chromium.org Review-Url: https://codereview.chromium.org/2895583004 . Cr-Commit-Position: refs/heads/master@{#473292} Committed: https://chromium.googlesource.com/chromium/src/+/7d38657a69469a0c14213e9be65bfe1d682abef2

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M build/config/fuchsia/BUILD.gn View 1 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Nico
(hans: I'm using 5.0.0 instead of clang_version since this path is in the fuchsia sdk, ...
3 years, 7 months ago (2017-05-19 19:52:14 UTC) #2
scottmg
Ooooh, thank you! lgtm
3 years, 7 months ago (2017-05-19 19:53:18 UTC) #5
scottmg
https://codereview.chromium.org/2895583004/diff/1/build/config/fuchsia/BUILD.gn File build/config/fuchsia/BUILD.gn (right): https://codereview.chromium.org/2895583004/diff/1/build/config/fuchsia/BUILD.gn#newcode29 build/config/fuchsia/BUILD.gn:29: # the SDK. Maybe link crbug.com/724204 here.
3 years, 7 months ago (2017-05-19 19:53:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895583004/1
3 years, 7 months ago (2017-05-19 19:54:30 UTC) #9
Nico
https://codereview.chromium.org/2895583004/diff/1/build/config/fuchsia/BUILD.gn File build/config/fuchsia/BUILD.gn (right): https://codereview.chromium.org/2895583004/diff/1/build/config/fuchsia/BUILD.gn#newcode29 build/config/fuchsia/BUILD.gn:29: # the SDK. On 2017/05/19 19:53:55, scottmg wrote: > ...
3 years, 7 months ago (2017-05-19 19:54:56 UTC) #10
Nico
3 years, 7 months ago (2017-05-19 19:55:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7d38657a69469a0c14213e9be65bfe1d682abef2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698