PaymentHandler: Clear storage partition data during content_browsertests.

PaymentHandler: Clear storage partition data during content_browsertests.

When PaymentAppInvocation test runs in single-process mode, the following
problem occurs in local environment:
  content_browsertests --gtest_filter=PaymentAppBrowserTest.* --single-process

  ../../content/browser/payments/payment_app_browsertest.cc:127: Failure
      Expected: 1U
      Which is: 1
  To be equal to: ids.size()
      Which is: 2

We can resolve this issue by clearing storage partition similar to what we do
in the background sync or the push messaging.
Please see: https://bugs.chromium.org/p/chromium/issues/detail?id=482083

BUG=661608
Review-Url: https://codereview.chromium.org/2895583002
Cr-Commit-Position: refs/heads/master@{#473619}
Committed: https://chromium.googlesource.com/chromium/src/+/af124f87be0846b2541f69d306c0bb705b5e9e9f

[zino, 2017-05-19 10:03:53]

Description was changed from

==========
PaymentHandler: Clear storage partition data during content_browsertests.

When PaymentAppInvocation test runs in single-process mode, the following
problem occurs in local environment:
  content_browsertests --gtest_filter=PaymentAppBrowserTest.* --single-process

We can resolve this issue by clearing storage partition similar to what we do
in the background sync or the push messaging.
Please see: https://bugs.chromium.org/p/chromium/issues/detail?id=482083

BUG=661608
==========

to

==========
PaymentHandler: Clear storage partition data during content_browsertests.

When PaymentAppInvocation test runs in single-process mode, the following
problem occurs in local environment:
  content_browsertests --gtest_filter=PaymentAppBrowserTest.* --single-process

  ../../content/browser/payments/payment_app_browsertest.cc:127: Failure
      Expected: 1U
      Which is: 1
  To be equal to: ids.size()
      Which is: 2

We can resolve this issue by clearing storage partition similar to what we do
in the background sync or the push messaging.
Please see: https://bugs.chromium.org/p/chromium/issues/detail?id=482083

BUG=661608
==========

[zino, 2017-05-19 10:05:38]

jinho.bang@samsung.com changed reviewers:
+ rouslan@chromium.org

[zino, 2017-05-19 10:05:45]

PTAL

[please use gerrit instead, 2017-05-19 14:23:43]

https://codereview.chromium.org/2895583002/diff/1/content/browser/payments/pa...
File content/browser/payments/payment_app_browsertest.cc (right):

https://codereview.chromium.org/2895583002/diff/1/content/browser/payments/pa...
content/browser/payments/payment_app_browsertest.cc:140: run_loop.Run();
Can you replace this implementation with these three statements? clang-format
will make it pretty.

base::RunLoop run_loop;

static_cast<StoragePartitionImpl*>(content::BrowserContext::GetDefaultStoragePartition(shell()->web_contents()->GetBrowserContext()))->ClearData(StoragePartition::REMOVE_DATA_MASK_SERVICE_WORKERS,
StoragePartition::QUOTA_MANAGED_STORAGE_MASK_ALL, GURL(),
StoragePartition::OriginMatcherFunction(), base::Time(), base::Time::Max(),
run_loop.QuitClosure());

run_loop.Run();

[zino, 2017-05-21 11:52:58]

Thank you for review.

PTAL

https://codereview.chromium.org/2895583002/diff/1/content/browser/payments/pa...
File content/browser/payments/payment_app_browsertest.cc (right):

https://codereview.chromium.org/2895583002/diff/1/content/browser/payments/pa...
content/browser/payments/payment_app_browsertest.cc:140: run_loop.Run();
On 2017/05/19 14:23:43, ಠ_ಠ wrote:
> Can you replace this implementation with these three statements? clang-format
> will make it pretty.
> 
> base::RunLoop run_loop;
> 
>
static_cast<StoragePartitionImpl*>(content::BrowserContext::GetDefaultStoragePartition(shell()->web_contents()->GetBrowserContext()))->ClearData(StoragePartition::REMOVE_DATA_MASK_SERVICE_WORKERS,
> StoragePartition::QUOTA_MANAGED_STORAGE_MASK_ALL, GURL(),
> StoragePartition::OriginMatcherFunction(), base::Time(), base::Time::Max(),
> run_loop.QuitClosure());
> 
> run_loop.Run();

Done.

[please use gerrit instead, 2017-05-22 13:52:00]

lgtm

[zino, 2017-05-22 17:08:50]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2017-05-22 17:09:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 17:56:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495472930571240,
"parent_rev": "3374eeb70e0834cffcf3a9723e8a67042ded551b", "commit_rev":
"af124f87be0846b2541f69d306c0bb705b5e9e9f"}

[commit-bot: I haz the power, 2017-05-22 17:57:00]

Description was changed from

==========
PaymentHandler: Clear storage partition data during content_browsertests.

When PaymentAppInvocation test runs in single-process mode, the following
problem occurs in local environment:
  content_browsertests --gtest_filter=PaymentAppBrowserTest.* --single-process

  ../../content/browser/payments/payment_app_browsertest.cc:127: Failure
      Expected: 1U
      Which is: 1
  To be equal to: ids.size()
      Which is: 2

We can resolve this issue by clearing storage partition similar to what we do
in the background sync or the push messaging.
Please see: https://bugs.chromium.org/p/chromium/issues/detail?id=482083

BUG=661608
==========

to

==========
PaymentHandler: Clear storage partition data during content_browsertests.

When PaymentAppInvocation test runs in single-process mode, the following
problem occurs in local environment:
  content_browsertests --gtest_filter=PaymentAppBrowserTest.* --single-process

  ../../content/browser/payments/payment_app_browsertest.cc:127: Failure
      Expected: 1U
      Which is: 1
  To be equal to: ids.size()
      Which is: 2

We can resolve this issue by clearing storage partition similar to what we do
in the background sync or the push messaging.
Please see: https://bugs.chromium.org/p/chromium/issues/detail?id=482083

BUG=661608

Review-Url: https://codereview.chromium.org/2895583002
Cr-Commit-Position: refs/heads/master@{#473619}
Committed:
https://chromium.googlesource.com/chromium/src/+/af124f87be0846b2541f69d306c0...
==========

[commit-bot: I haz the power, 2017-05-22 17:57:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/af124f87be0846b2541f69d306c0...