Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 2895563002: Naively implement WorkerFetchContext::ShouldBlockFetchByMixedContentCheck() (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by horo
Modified:
2 months, 1 week ago
Reviewers:
kinuko
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Naively implement WorkerFetchContext::ShouldBlockFetchByMixedContentCheck() We need more detailed check which is implemented in MixedContentChecker::ShouldBlockFetch(). It take time to implement it for workers. And returning false is a bit scary from the security point of view. So I want to use MixedContentChecker::IsMixedContent() for a while. BUG=443374 Review-Url: https://codereview.chromium.org/2895563002 Cr-Commit-Position: refs/heads/master@{#473397} Committed: https://chromium.googlesource.com/chromium/src/+/3b77f4e721998b5fb72fd1039b14e926823527b8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -37 lines) Patch
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/external/wpt/service-workers/service-worker/fetch-mixed-content-to-inscope.https-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/external/wpt/service-workers/service-worker/fetch-mixed-content-to-outscope.https-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/fetch/workers/block-mixed-content-base-https-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/fetch/workers/block-mixed-content-nocors-base-https-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/loader/WorkerFetchContext.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
Commit queue not available (can’t edit this change).

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
horo
kinuko@ Could you please review this?
2 months, 1 week ago (2017-05-19 08:05:14 UTC) #5
kinuko
lgtm
2 months, 1 week ago (2017-05-19 15:03:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895563002/1
2 months, 1 week ago (2017-05-19 23:01:29 UTC) #10
commit-bot: I haz the power
2 months, 1 week ago (2017-05-20 00:48:27 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3b77f4e721998b5fb72fd1039b14...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 25c286973