[Extensions Bindings] Move directory util out of runtime_custom_bindings

chrome/renderer/resources/extensions/file_entry_binding_util.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var fileSystemNatives = requireNative('file_system_natives');
 var GetIsolatedFileSystem = fileSystemNatives.GetIsolatedFileSystem;
 var lastError = require('lastError');
 var GetModuleSystem = requireNative('v8_context').GetModuleSystem;
 // TODO(sammc): Don't require extension. See http://crbug.com/235689.
 var GetExtensionViews = requireNative('runtime').GetExtensionViews;
 var safeCallbackApply = require('uncaught_exception_handler').safeCallbackApply;
 
+var WINDOW = {};
+try {
+  WINDOW = window;
+} catch (e) {
+  // Running in SW context.
+  // TODO(lazyboy): Synchronous access to background page is not possible from
+  // service worker context. Decide what we should do in this case for the class
+  // of APIs that require access to background page or window object
+}
+
 // For a given |apiName|, generates object with two elements that are used
 // in file system relayed APIs:
 // * 'bindFileEntryCallback' function that provides mapping between JS objects
 //   into actual FileEntry|DirectoryEntry objects.
 // * 'entryIdManager' object that implements methods for keeping the tracks of
 //   previously saved file entries.
 function getFileBindingsForApi(apiName) {
   // Fallback to using the current window if no background page is running.
-  var backgroundPage = GetExtensionViews(-1, -1, 'BACKGROUND')[0] || window;
+  var backgroundPage = GetExtensionViews(-1, -1, 'BACKGROUND')[0] || WINDOW;
   var backgroundPageModuleSystem = GetModuleSystem(backgroundPage);
 
   // All windows use the bindFileEntryCallback from the background page so their
   // FileEntry objects have the background page's context as their own. This
   // allows them to be used from other windows (including the background page)
   // after the original window is closed.
-  if (window == backgroundPage) {
+  if (WINDOW == backgroundPage) {
     var bindFileEntryCallback = function(functionName, apiFunctions) {
       apiFunctions.setCustomCallback(functionName,
           function(name, request, callback, response) {
         if (callback) {
           if (!response) {
             callback();
             return;
           }
 
           var entries = [];
@@ skipping 72 matching lines @@
     backgroundPage.chrome.fileSystem;
     var bindFileEntryCallback =
         backgroundPageModuleSystem.require('fileEntryBindingUtil')
             .getFileBindingsForApi(apiName).bindFileEntryCallback;
     var entryIdManager = backgroundPageModuleSystem.require('entryIdManager');
   }
   return {bindFileEntryCallback: bindFileEntryCallback,
           entryIdManager: entryIdManager};
 }
 
+function getBindDirectoryEntryCallback() {
+  // Get the background page if one exists. Otherwise, default to the current
+  // window.
+  var backgroundPage = GetExtensionViews(-1, -1, 'BACKGROUND')[0] || WINDOW;
+  var backgroundPageModuleSystem = GetModuleSystem(backgroundPage);

[lazyboy, 2017/05/19 21:03:51]

Should we move this close to where it is required and used? i.e. close to line
171 below.

[Devlin, 2017/05/20 00:50:40]

Done.

+
+  // For packaged apps, all windows use the bindFileEntryCallback from the
+  // background page so their FileEntry objects have the background page's
+  // context as their own. This allows them to be used from other windows
+  // (including the background page) after the original window is closed.
+  if (WINDOW == backgroundPage) {
+    return function(name, request, callback, response) {
+      if (callback) {
+        if (!response) {
+          callback();
+          return;
+        }
+        var fileSystemId = response.fileSystemId;
+        var baseName = response.baseName;
+        var fs = GetIsolatedFileSystem(fileSystemId);
+
+        try {
+          fs.root.getDirectory(baseName, {}, callback, function(fileError) {
+            lastError.run('runtime.' + functionName,
+                          'Error getting Entry, code: ' + fileError.code,
+                          request.stack,
+                          callback);
+          });
+        } catch (e) {
+          lastError.run('runtime.' + functionName,
+                        'Error: ' + e.stack,
+                        request.stack,
+                        callback);
+        }
+      }
+    }
+  } else {
+    // Force the runtime API to be loaded in the background page. Using
+    // backgroundPageModuleSystem.require('runtime') is insufficient as
+    // requireNative is only allowed while lazily loading an API.
+    backgroundPage.chrome.runtime;
+    return backgroundPageModuleSystem.require('fileEntryBindingUtil')
+               .getBindDirectoryEntryCallback().bindDirectoryEntryCallback;
+  }
+}
+
 exports.$set('getFileBindingsForApi', getFileBindingsForApi);
+exports.$set('getBindDirectoryEntryCallback', getBindDirectoryEntryCallback);