Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2895493004: [Extensions Bindings] Move directory util out of runtime_custom_bindings (Closed)

Created:
3 years, 7 months ago by Devlin
Modified:
3 years, 7 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, jbroman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Bindings] Move directory util out of runtime_custom_bindings The chrome.runtime API has a method called `getPackageDirectoryEntry` which has custom bindings to retrieve the app's directory entry (a la HTML5 filesystem) and return it. The custom bindings for this are quite strange, since it needs to be done from the app's background page. Move this to the file_entry_binding_util.js file, where the similar getFileBindingsForApi() function is implemented. In addition to grouping similar logic, this solves a native bindings issue where with trying to require an API directly (which is disallowed). BUG=653596 TBR=michaelpg@chromium.org (moving a resource) Review-Url: https://codereview.chromium.org/2895493004 Cr-Commit-Position: refs/heads/master@{#473977} Committed: https://chromium.googlesource.com/chromium/src/+/e7369ba071f382a1b3906a78da6517af0b23dc26

Patch Set 1 #

Total comments: 2

Patch Set 2 : Shuffle files #

Patch Set 3 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -297 lines) Patch
M chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/file_entry_binding_util.js View 1 1 chunk +0 lines, -121 lines 0 comments Download
M chrome/renderer/resources/renderer_resources.grd View 1 1 chunk +0 lines, -1 line 0 comments Download
M extensions/renderer/dispatcher.cc View 1 1 chunk +96 lines, -94 lines 2 comments Download
M extensions/renderer/resources/extensions_renderer_resources.grd View 1 1 chunk +1 line, -0 lines 0 comments Download
A + extensions/renderer/resources/file_entry_binding_util.js View 1 2 3 chunks +59 lines, -2 lines 0 comments Download
M extensions/renderer/resources/runtime_custom_bindings.js View 2 chunks +4 lines, -77 lines 0 comments Download

Messages

Total messages: 24 (15 generated)
Devlin
lazyboy@, mind taking a look? jbroman@, FYI. Just moving stuff around.
3 years, 7 months ago (2017-05-19 20:30:11 UTC) #2
lazyboy
lgtm https://codereview.chromium.org/2895493004/diff/1/chrome/renderer/resources/extensions/file_entry_binding_util.js File chrome/renderer/resources/extensions/file_entry_binding_util.js (right): https://codereview.chromium.org/2895493004/diff/1/chrome/renderer/resources/extensions/file_entry_binding_util.js#newcode135 chrome/renderer/resources/extensions/file_entry_binding_util.js:135: var backgroundPageModuleSystem = GetModuleSystem(backgroundPage); Should we move this ...
3 years, 7 months ago (2017-05-19 21:03:52 UTC) #5
Devlin
Note: I had to move file_entry_binding_util to //extensions. I think that makes sense since it's ...
3 years, 7 months ago (2017-05-20 00:50:40 UTC) #10
lazyboy
lgtm, sorry didn't notice earlier. https://codereview.chromium.org/2895493004/diff/40001/extensions/renderer/dispatcher.cc File extensions/renderer/dispatcher.cc (right): https://codereview.chromium.org/2895493004/diff/40001/extensions/renderer/dispatcher.cc#newcode699 extensions/renderer/dispatcher.cc:699: {"appView", IDR_APP_VIEW_JS}, I'm guessing ...
3 years, 7 months ago (2017-05-20 02:18:16 UTC) #13
Devlin
https://codereview.chromium.org/2895493004/diff/40001/extensions/renderer/dispatcher.cc File extensions/renderer/dispatcher.cc (right): https://codereview.chromium.org/2895493004/diff/40001/extensions/renderer/dispatcher.cc#newcode699 extensions/renderer/dispatcher.cc:699: {"appView", IDR_APP_VIEW_JS}, On 2017/05/20 02:18:15, lazyboy wrote: > I'm ...
3 years, 7 months ago (2017-05-23 17:17:16 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895493004/40001
3 years, 7 months ago (2017-05-23 17:18:08 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/445024)
3 years, 7 months ago (2017-05-23 17:28:23 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895493004/40001
3 years, 7 months ago (2017-05-23 17:30:55 UTC) #21
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 18:13:00 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e7369ba071f382a1b3906a78da65...

Powered by Google App Engine
This is Rietveld 408576698