Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: gpu/command_buffer/service/framebuffer_manager_unittest.cc

Issue 2895493002: Fix fbo completeness check when non-base-level texture image is attached. (Closed)
Patch Set: handle a bug related to TexStorage Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/framebuffer_manager_unittest.cc
diff --git a/gpu/command_buffer/service/framebuffer_manager_unittest.cc b/gpu/command_buffer/service/framebuffer_manager_unittest.cc
index b3647d0c646d7e4f2321efeaf353a67528b97604..513a2194c6442defa5e070c2051909279abf2bea 100644
--- a/gpu/command_buffer/service/framebuffer_manager_unittest.cc
+++ b/gpu/command_buffer/service/framebuffer_manager_unittest.cc
@@ -1649,7 +1649,43 @@ TEST_F(FramebufferInfoES3Test, ReadBuffer) {
EXPECT_TRUE(framebuffer_->GetReadBufferAttachment());
}
-} // namespace gles2
-} // namespace gpu
+TEST_F(FramebufferInfoES3Test, AttachNonLevel0Texture) {
+ const GLuint kTextureClientId = 33;
+ const GLuint kTextureServiceId = 333;
+ const GLint kBorder = 0;
+ const GLenum kType = GL_UNSIGNED_BYTE;
+ const GLsizei kWidth = 16;
+ const GLsizei kHeight = 32;
+ const GLint kLevel = 2;
+ const GLenum kInternalFormat = GL_RGBA8;
+ const GLenum kFormat = GL_RGBA;
+ const GLenum kTarget = GL_TEXTURE_2D;
+ const GLsizei kSamples = 0;
+
+ texture_manager_->CreateTexture(kTextureClientId, kTextureServiceId);
+ scoped_refptr<TextureRef> texture(
+ texture_manager_->GetTexture(kTextureClientId));
+ ASSERT_TRUE(texture.get());
+
+ texture_manager_->SetTarget(texture.get(), kTarget);
+ texture_manager_->SetLevelInfo(texture.get(), kTarget, kLevel,
+ kInternalFormat, kWidth, kHeight, 0, kBorder,
+ kFormat, kType, gfx::Rect());
+ framebuffer_->AttachTexture(GL_COLOR_ATTACHMENT0, texture.get(), kTarget,
+ kLevel, kSamples);
+ EXPECT_EQ(static_cast<GLenum>(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT),
+ framebuffer_->IsPossiblyComplete(feature_info_.get()));
+ EXPECT_CALL(*gl_, TexParameteri(kTarget, GL_TEXTURE_BASE_LEVEL, kLevel))
+ .Times(1)
+ .RetiresOnSaturation();
+ texture_manager_->SetParameteri("FramebufferInfoTest.AttachNonLevel0Texturer",
+ error_state_.get(), texture.get(),
+ GL_TEXTURE_BASE_LEVEL, kLevel);
+ EXPECT_EQ(static_cast<GLenum>(GL_FRAMEBUFFER_COMPLETE),
+ framebuffer_->IsPossiblyComplete(feature_info_.get()));
+}
+
+} // namespace gles2
+} // namespace gpu
« no previous file with comments | « gpu/command_buffer/service/framebuffer_manager.cc ('k') | gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698