Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: gpu/command_buffer/service/framebuffer_manager.cc

Issue 2895493002: Fix fbo completeness check when non-base-level texture image is attached. (Closed)
Patch Set: handle a bug related to TexStorage Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gpu/command_buffer/service/framebuffer_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/framebuffer_manager.cc
diff --git a/gpu/command_buffer/service/framebuffer_manager.cc b/gpu/command_buffer/service/framebuffer_manager.cc
index 55ed2e1a1f8e1bec6ef38e86b8c8bea46d9b11df..637c6b70e53c8cc794bbc867e9566fc4c9c4cad2 100644
--- a/gpu/command_buffer/service/framebuffer_manager.cc
+++ b/gpu/command_buffer/service/framebuffer_manager.cc
@@ -243,6 +243,9 @@ class TextureAttachment
}
bool IsLayerValid() const override {
+ if (!Is3D()) {
+ return true;
+ }
Texture* texture = texture_ref_->texture();
DCHECK(texture);
GLsizei width, height, depth;
« no previous file with comments | « no previous file | gpu/command_buffer/service/framebuffer_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698