[heap] Simplify and scale ResourceConstraints::ConfigureDefaults.

[heap] Simplify and linearly scale ResourceConstraints::ConfigureDefaults.

Perf Sheriffs: This CL may change performance on various benchmarks.

BUG=chromium:716032
Review-Url: https://codereview.chromium.org/2895473003
Cr-Commit-Position: refs/heads/master@{#45495}
Committed: https://chromium.googlesource.com/v8/v8/+/d37dd4a66e3625714006cf51e6f2efa6154001f2

[Hannes Payer (out of office), 2017-05-19 11:19:45]

Description was changed from

==========
[heap] Simplify and linearly scale ResourceConstraints::ConfigureDefaults.

BUG=chromium:716032
==========

to

==========
[heap] Simplify and linearly scale ResourceConstraints::ConfigureDefaults.

Perf Sheriffs: This CL may change performance on various benchmarks.

BUG=chromium:716032
==========

[Hannes Payer (out of office), 2017-05-19 11:19:45]

hpayer@chromium.org changed reviewers:
+ mcilroy@chromium.org, ulan@chromium.org

[Hannes Payer (out of office), 2017-05-19 11:39:57]

https://codereview.chromium.org/2895473003/diff/1/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/2895473003/diff/1/src/heap/heap.h#newcode949
src/heap/heap.h:949: const int kMaxOldSpaceSizeLowMemoryDevice = 128 *
kPointerMultiplier;
I will remove these two methods in a follow-up CL. I am keeping the constants
until then local in these methods.

[Hannes Payer (out of office), 2017-05-22 15:53:15]

The CQ bit was checked by hpayer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 15:53:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 16:28:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 16:28:14]

Dry run: This issue passed the CQ dry run.

[Hannes Payer (out of office), 2017-05-22 17:19:12]

The CQ bit was checked by hpayer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 17:19:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 17:38:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 17:38:23]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[Hannes Payer (out of office), 2017-05-23 09:31:26]

The CQ bit was checked by hpayer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 09:31:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hannes Payer (out of office), 2017-05-23 09:36:41]

The CQ bit was checked by hpayer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 09:36:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 09:40:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 09:40:20]

Dry run: Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/22942)
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[Hannes Payer (out of office), 2017-05-23 09:57:34]

The CQ bit was checked by hpayer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 09:57:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 10:47:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 10:47:26]

Dry run: This issue passed the CQ dry run.

[Hannes Payer (out of office), 2017-05-23 14:45:08]

The CQ bit was checked by hpayer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 14:45:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hannes Payer (out of office), 2017-05-23 14:54:32]

The CQ bit was checked by hpayer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 14:54:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 15:29:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 15:29:03]

Dry run: This issue passed the CQ dry run.

[ulan, 2017-05-23 16:27:49]

lgtm

https://codereview.chromium.org/2895473003/diff/140001/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/2895473003/diff/140001/src/heap/heap.h#newcod...
src/heap/heap.h:1359: uint64_t rounded_physical_memory =
maybe call this capped_physical_memory?

[Hannes Payer (out of office), 2017-05-23 16:30:14]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2017-05-23 16:30:14]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/2895473003/#ps150001
(title: "rename")

[commit-bot: I haz the power, 2017-05-23 16:30:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hannes Payer (out of office), 2017-05-23 16:30:19]

https://codereview.chromium.org/2895473003/diff/140001/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/2895473003/diff/140001/src/heap/heap.h#newcod...
src/heap/heap.h:1359: uint64_t rounded_physical_memory =
On 2017/05/23 16:27:49, ulan wrote:
> maybe call this capped_physical_memory?

Done.

[commit-bot: I haz the power, 2017-05-23 17:00:57]

CQ is committing da patch.

Bot data: {"patchset_id": 150001, "attempt_start_ts": 1495557014359410,
"parent_rev": "611ec69d85c44b1ff1616f1aa60c3de83b56e69d", "commit_rev":
"d37dd4a66e3625714006cf51e6f2efa6154001f2"}

[commit-bot: I haz the power, 2017-05-23 17:01:04]

Description was changed from

==========
[heap] Simplify and linearly scale ResourceConstraints::ConfigureDefaults.

Perf Sheriffs: This CL may change performance on various benchmarks.

BUG=chromium:716032
==========

to

==========
[heap] Simplify and linearly scale ResourceConstraints::ConfigureDefaults.

Perf Sheriffs: This CL may change performance on various benchmarks.

BUG=chromium:716032

Review-Url: https://codereview.chromium.org/2895473003
Cr-Commit-Position: refs/heads/master@{#45495}
Committed:
https://chromium.googlesource.com/v8/v8/+/d37dd4a66e3625714006cf51e6f2efa6154...
==========

[commit-bot: I haz the power, 2017-05-23 17:01:05]

Committed patchset #9 (id:150001) as
https://chromium.googlesource.com/v8/v8/+/d37dd4a66e3625714006cf51e6f2efa6154...