Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 2895473002: Upstream service worker "timing" test to WPT (Closed)

Created:
3 years, 7 months ago by mike3
Modified:
3 years, 7 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, blink-reviews-w3ctests_chromium.org, nhiroki, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream service worker "timing" test to WPT The version of this test in the Chromium source tree is equivalent to the version available in the Web Platform Tests project. The WPT version was previously marked as an expected failure because it constructed URLs in terms of the HTTP protocol. This is correct within the Chromium infrastructure (where the "secure context" requirement of the service worker specification is satisfied by the use of the origin `127.0.0.1`), but it is inappropriate for use within the WPT testing infrastructure (where HTTPS is used to provide a secure context). Correct the upstream version of the test, remove Chromium's "expected failure" file, and remove the Chromium version of the test. BUG=688116, 678905 R=falken@chromium.org Review-Url: https://codereview.chromium.org/2895473002 Cr-Commit-Position: refs/heads/master@{#473206} Committed: https://chromium.googlesource.com/chromium/src/+/9a736f232d37141444b55fc6a3d36eb78f8c86ec

Patch Set 1 #

Messages

Total messages: 7 (4 generated)
falken
lgtm. great! Add 678905 to BUG= since this technically fixed a WPT test :)
3 years, 7 months ago (2017-05-19 04:03:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895473002/1
3 years, 7 months ago (2017-05-19 14:44:13 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 16:00:14 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9a736f232d37141444b55fc6a3d3...

Powered by Google App Engine
This is Rietveld 408576698