Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2895413002: WebRuntimeFeatures moved to platform/ (Closed)

Created:
3 years, 7 months ago by nverne
Modified:
3 years, 7 months ago
CC:
alokp+watch_chromium.org, apacible+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, einbinder+watch-test-runner_chromium.org, erickung+watch_chromium.org, estade+watch_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, fuzzing_chromium.org, grt+watch_chromium.org, halliwell+watch_chromium.org, horo+watch_chromium.org, jam, jochen+watch_chromium.org, jsbell+serviceworker_chromium.org, kinuko+serviceworker, kinuko+watch, lcwu+watch_chromium.org, mathp+autofillwatch_chromium.org, mfoltz+watch_chromium.org, michaeln, miu+watch_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, nasko+codewatch_chromium.org, nhiroki, Peter Beverloo, piman+watch_chromium.org, rogerm+autofillwatch_chromium.org, rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, serviceworker-reviews, shimazu+serviceworker_chromium.org, timvolodine, tzik, vabr+watchlistautofill_chromium.org, vakh+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WebRuntimeFeatures moved to platform/ BUG=chromium:723482 Review-Url: https://codereview.chromium.org/2895413002 Cr-Commit-Position: refs/heads/master@{#474239} Committed: https://chromium.googlesource.com/chromium/src/+/61d2da8726d19192add48211792c0ec9a09fe58d

Patch Set 1 #

Patch Set 2 : remove unused #includes #

Patch Set 3 : One more move #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -591 lines) Patch
M chrome/renderer/autofill/form_classifier_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/threat_dom_details_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/renderer/cast_content_renderer_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/runtime_features.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/service_worker/web_service_worker_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/render_view_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/render_widget.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/renderer_main_platform_delegate_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/layout_test/layout_test_content_renderer_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/blink_test_environment.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/fuzzer/fuzzer_support.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_blink_web_unit_test_support.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/dispatcher.cc View 2 chunks +1 line, -1 line 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 chunk +0 lines, -411 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 2 2 chunks +1 line, -1 line 0 comments Download
A third_party/WebKit/public/platform/WebRuntimeFeatures.h View 1 chunk +167 lines, -0 lines 0 comments Download
D third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 chunk +0 lines, -160 lines 0 comments Download

Messages

Total messages: 30 (18 generated)
nverne
3 years, 7 months ago (2017-05-23 04:20:27 UTC) #7
nverne
3 years, 7 months ago (2017-05-23 05:59:59 UTC) #9
joelhockey
lgtm fyi: You can use gerrit by default for code reviews with command: git config ...
3 years, 7 months ago (2017-05-23 06:33:37 UTC) #12
nverne
3 years, 7 months ago (2017-05-23 19:22:54 UTC) #16
slangley
lgtm
3 years, 7 months ago (2017-05-23 21:55:26 UTC) #17
kinuko
cool, lgtm
3 years, 7 months ago (2017-05-24 00:08:47 UTC) #18
haraken
LGTM
3 years, 7 months ago (2017-05-24 00:12:34 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895413002/40001
3 years, 7 months ago (2017-05-24 03:44:44 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/445801)
3 years, 7 months ago (2017-05-24 03:55:52 UTC) #23
jochen (gone - plz use gerrit)
lgtm
3 years, 7 months ago (2017-05-24 06:44:37 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895413002/40001
3 years, 7 months ago (2017-05-24 06:53:41 UTC) #27
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 10:15:47 UTC) #30
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/61d2da8726d19192add48211792c...

Powered by Google App Engine
This is Rietveld 408576698