Fixed WebUIMojoTest.MessageExchange tests and marked as FLAKY.

Fixed WebUIMojoTest.MessageExchange tests and marked as FLAKY.

Notable changes:
 - Do not use WaitForCondition method that times out (tests should not
   timeout) and use one that returns bool.
 - Moved setup code from constructor to SetUp, so it is executed after
   the server actually started.
 - Increased timeout for the test to 5 seconds, which is a reasonable
   timeout to allow page load and one roundtrip message exchange.
 - Marked test as flaky to let it run on bots before fully enabling it.

BUG=720098
Review-Url: https://codereview.chromium.org/2895333003
Cr-Commit-Position: refs/heads/master@{#473765}
Committed: https://chromium.googlesource.com/chromium/src/+/267131adcedfb11f96f23c54cafb6cbfa03f6f1c

[Eugene But (OOO till 7-30), 2017-05-22 23:02:36]

eugenebut@chromium.org changed reviewers:
+ baxley@chromium.org

[baxley, 2017-05-22 23:17:08]

lgtm

https://codereview.chromium.org/2895333003/diff/1/ios/web/webui/web_ui_mojo_i...
File ios/web/webui/web_ui_mojo_inttest.mm (right):

https://codereview.chromium.org/2895333003/diff/1/ios/web/webui/web_ui_mojo_i...
ios/web/webui/web_ui_mojo_inttest.mm:36: const NSTimeInterval kMessageTimeout[]
= 5.0;
Is this supposed to be an array?

[Eugene But (OOO till 7-30), 2017-05-23 00:25:21]

Thanks!

https://codereview.chromium.org/2895333003/diff/1/ios/web/webui/web_ui_mojo_i...
File ios/web/webui/web_ui_mojo_inttest.mm (right):

https://codereview.chromium.org/2895333003/diff/1/ios/web/webui/web_ui_mojo_i...
ios/web/webui/web_ui_mojo_inttest.mm:36: const NSTimeInterval kMessageTimeout[]
= 5.0;
On 2017/05/22 23:17:08, baxley wrote:
> Is this supposed to be an array?
Nope, this does not even compile :( removed brackets.

[Eugene But (OOO till 7-30), 2017-05-23 00:25:25]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-05-23 00:25:25]

The patchset sent to the CQ was uploaded after l-g-t-m from baxley@chromium.org
Link to the patchset: https://codereview.chromium.org/2895333003/#ps20001
(title: "Fixed compilation")

[commit-bot: I haz the power, 2017-05-23 00:26:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 00:39:48]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495499125023410,
"parent_rev": "424d27cceaba0271bc21e9c9b48a39e4d5a2b21f", "commit_rev":
"267131adcedfb11f96f23c54cafb6cbfa03f6f1c"}

[commit-bot: I haz the power, 2017-05-23 00:40:07]

Description was changed from

==========
Fixed WebUIMojoTest.MessageExchange tests and marked as FLAKY.

Notable changes:
 - Do not use WaitForCondition method that times out (tests should not
   timeout) and use one that returns bool.
 - Moved setup code from constructor to SetUp, so it is executed after
   the server actually started.
 - Increased timeout for the test to 5 seconds, which is a reasonable
   timeout to allow page load and one roundtrip message exchange.
 - Marked test as flaky to let it run on bots before fully enabling it.

BUG=720098
==========

to

==========
Fixed WebUIMojoTest.MessageExchange tests and marked as FLAKY.

Notable changes:
 - Do not use WaitForCondition method that times out (tests should not
   timeout) and use one that returns bool.
 - Moved setup code from constructor to SetUp, so it is executed after
   the server actually started.
 - Increased timeout for the test to 5 seconds, which is a reasonable
   timeout to allow page load and one roundtrip message exchange.
 - Marked test as flaky to let it run on bots before fully enabling it.

BUG=720098

Review-Url: https://codereview.chromium.org/2895333003
Cr-Commit-Position: refs/heads/master@{#473765}
Committed:
https://chromium.googlesource.com/chromium/src/+/267131adcedfb11f96f23c54cafb...
==========

[commit-bot: I haz the power, 2017-05-23 00:40:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/267131adcedfb11f96f23c54cafb...