Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2895323002: Change string data instead of binary in content settings. (Closed)

Created:
3 years, 7 months ago by Jialiu Lin
Modified:
3 years, 7 months ago
Reviewers:
Sam McNally
CC:
chromium-reviews, grt+watch_chromium.org, vakh+watch_chromium.org, timvolodine
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change string data instead of binary in content settings. BUG=724905 Review-Url: https://codereview.chromium.org/2895323002 Cr-Commit-Position: refs/heads/master@{#473750} Committed: https://chromium.googlesource.com/chromium/src/+/ee69e6f69b1498d2f7b91a8e8ffc2a77603951e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -21 lines) Patch
M components/safe_browsing/password_protection/password_protection_service.cc View 3 chunks +13 lines, -21 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Jialiu Lin
Hi sammc@, Could you take a look? Thanks!
3 years, 7 months ago (2017-05-22 18:35:06 UTC) #4
Sam McNally
lgtm
3 years, 7 months ago (2017-05-22 23:25:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895323002/1
3 years, 7 months ago (2017-05-22 23:53:07 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 23:59:20 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ee69e6f69b1498d2f7b91a8e8ffc...

Powered by Google App Engine
This is Rietveld 408576698